Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move _Width_estimate_intervals_v2 to __msvc_format_ucd_tables.hpp #4446

Merged
merged 4 commits into from
Mar 8, 2024

Conversation

cpplearner
Copy link
Contributor

Another attempt to make it easier to update the Unicode data.

This PR modifies grapheme_break_property_data_gen.py (to be renamed by #4435) to additionally produce the definition of _Width_estimate_intervals_v2, regenerates __msvc_format_ucd_tables.hpp using that script, and removes the old array from <format>.

As a drive-by fix, this PR fixes the small divergence between __msvc_format_ucd_tables.hpp and grapheme_break_property_data_gen.py, introduced by #3721's manual editing of __msvc_format_ucd_tables.hpp.

Note that this makes _Width_estimate_intervals_v2 covered by the copyright notice in __msvc_format_ucd_tables.hpp.

@cpplearner cpplearner requested a review from a team as a code owner March 4, 2024 14:00
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Mar 4, 2024
@StephanTLavavej StephanTLavavej self-assigned this Mar 4, 2024
@StephanTLavavej StephanTLavavej added the format C++20/23 format label Mar 5, 2024
@StephanTLavavej

This comment was marked as resolved.

@StephanTLavavej StephanTLavavej removed their assignment Mar 6, 2024
@StephanTLavavej
Copy link
Member

Although the product code is essentially unaffected, this is a sufficiently large change to the scripts that I'd like a second maintainer to review this.

@StephanTLavavej StephanTLavavej self-assigned this Mar 6, 2024
@StephanTLavavej
Copy link
Member

I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej
Copy link
Member

I've pushed a merge with main to pick up the script rename - interestingly, GitHub considered it a conflict, but git was happy to auto-merge (I've seen this happen before).

@StephanTLavavej StephanTLavavej merged commit 4378648 into microsoft:main Mar 8, 2024
35 checks passed
@StephanTLavavej
Copy link
Member

Thanks for unifying these scripts - it's such a simpler process to have a single generated file! 😻 💚 🚀

@cpplearner cpplearner deleted the width-estimate-intervals branch March 8, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something can be improved format C++20/23 format
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants