-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move _Width_estimate_intervals_v2
to __msvc_format_ucd_tables.hpp
#4446
Move _Width_estimate_intervals_v2
to __msvc_format_ucd_tables.hpp
#4446
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
tools/unicode_properties_parse/grapheme_break_property_data_gen.py
Outdated
Show resolved
Hide resolved
tools/unicode_properties_parse/grapheme_break_property_data_gen.py
Outdated
Show resolved
Hide resolved
Although the product code is essentially unaffected, this is a sufficiently large change to the scripts that I'd like a second maintainer to review this. |
I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
I've pushed a merge with |
Thanks for unifying these scripts - it's such a simpler process to have a single generated file! 😻 💚 🚀 |
Another attempt to make it easier to update the Unicode data.
This PR modifies
grapheme_break_property_data_gen.py
(to be renamed by #4435) to additionally produce the definition of_Width_estimate_intervals_v2
, regenerates__msvc_format_ucd_tables.hpp
using that script, and removes the old array from<format>
.As a drive-by fix, this PR fixes the small divergence between
__msvc_format_ucd_tables.hpp
andgrapheme_break_property_data_gen.py
, introduced by #3721's manual editing of__msvc_format_ucd_tables.hpp
.Note that this makes
_Width_estimate_intervals_v2
covered by the copyright notice in__msvc_format_ucd_tables.hpp
.