Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement LWG-4013 lazy_split_view::outer-iterator::value_type should not provide default constructor #4530

Merged
merged 3 commits into from
Mar 28, 2024

Conversation

frederick-vs-ja
Copy link
Contributor

@frederick-vs-ja frederick-vs-ja commented Mar 24, 2024

Fixes #4503.

Skips two libcxx tests:

  • std/ranges/range.adaptors/range.lazy.split/range.lazy.split.outer.value/ctor.default.pass.cpp
  • std/ranges/range.adaptors/range.lazy.split/range.lazy.split.outer.value/ctor.iter.pass.cpp

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner March 24, 2024 16:54
- std/ranges/range.adaptors/range.lazy.split/range.lazy.split.outer.value/ctor.iter.pass.cpp
- std/ranges/range.adaptors/range.lazy.split/range.lazy.split.outer.value/ctor.default.pass.cpp
@StephanTLavavej StephanTLavavej added LWG Library Working Group issue ranges C++20/23 ranges labels Mar 25, 2024
@StephanTLavavej StephanTLavavej self-assigned this Mar 25, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit d8f6dc5 into microsoft:main Mar 28, 2024
35 checks passed
@frederick-vs-ja frederick-vs-ja deleted the lwg-4013 branch March 28, 2024 18:01
@StephanTLavavej
Copy link
Member

Thanks for all of these LWG issue resolutions! 😻 📉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LWG Library Working Group issue ranges C++20/23 ranges
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

LWG-4013 lazy_split_view::outer-iterator::value_type should not provide default constructor
2 participants