Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P3142R0: Printing Blank Lines with println #4611

Merged

Conversation

H-G-Hristov
Copy link
Contributor

@H-G-Hristov H-G-Hristov commented Apr 20, 2024

@H-G-Hristov
Copy link
Contributor Author

@microsoft-github-policy-service agree

@StephanTLavavej StephanTLavavej added the cxx26 C++26 feature label Apr 20, 2024
@StephanTLavavej

This comment was marked as resolved.

@H-G-Hristov

This comment was marked as resolved.

@StephanTLavavej StephanTLavavej marked this pull request as ready for review April 22, 2024 08:58
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner April 22, 2024 08:58
@StephanTLavavej
Copy link
Member

/azp run STL-CI

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StephanTLavavej

This comment was marked as resolved.

@StephanTLavavej

This comment was marked as resolved.

@StephanTLavavej

This comment was marked as resolved.

stl/inc/ostream Show resolved Hide resolved
stl/inc/print Outdated Show resolved Hide resolved
@StephanTLavavej
Copy link
Member

Thanks! 😻 I pushed tiny changes to the product code, and then I figured out how to add test coverage without it hanging.

@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@H-G-Hristov
Copy link
Contributor Author

@StephanTLavavej I was quite busy and I wasn't able to respond earlier.
I pushed some changes without checking your latest comments first. Sorry about that. Should I revert those?

Basically the idea is to test println() alone. In libc++ I did that for other another reason though.

Thank you!

@H-G-Hristov
Copy link
Contributor Author

@StephanTLavavej I was quite busy and I wasn't able to respond earlier. I pushed some changes without checking your latest comments first. Sorry about that. Should I revert those?

Basically the idea is to test println() alone. In libc++ I did that for other another reason though.

Thank you!

I reverted those changes.

@StephanTLavavej
Copy link
Member

No worries, and thanks for the revert! I've already mirrored this to the MSVC-internal repo (stacked up with 20 other commits), so further changes would have reset that process.

If you'd like to add additional test coverage, followup PRs are always welcome after this has merged to main.

Of course, if you discover late-breaking correctness issues, it's always possible to rework or hold back a PR that's already been mirrored, we just like to avoid disrupting the process for "nice to have" changes.

@StephanTLavavej StephanTLavavej merged commit 34917ee into microsoft:main Apr 26, 2024
39 checks passed
@StephanTLavavej
Copy link
Member

Thanks again for implementing this feature, which is sure to be used by programmers from beginners to experts everywhere, and congratulations on your first microsoft/STL commit! 😻 🎉 🚀

This is expected to ship in VS 2022 17.11 Preview 2.

@H-G-Hristov
Copy link
Contributor Author

Thanks again for implementing this feature, which is sure to be used by programmers from beginners to experts everywhere, and congratulations on your first microsoft/STL commit! 😻 🎉 🚀

This is expected to ship in VS 2022 17.11 Preview 2.

Thank you very much for your support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cxx26 C++26 feature
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

P3142R0 Printing Blank Lines With println()
3 participants