-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test CUDA in all supported Standard modes. #4974
Conversation
…n `__msvc_all_public_headers.hpp`
…E_ALL_CXX17_DEPRECATION_WARNINGS` in CUDA test
I pushed a couple of commits to (1) address a comment nitpick, and (2) resolve the deprecation macro question by guarding the definition in |
Thanks! I'm still mystified as to why C++20 mode isn't emitting the C++17 deprecation warnings for C headers, or C++20's own deprecation warning for |
Wild guess: some predefined global warning suppression to avoid the force-included header emitting warnings? |
My guess: these headers are |
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks for this major improvement in test coverage! ✅ 📈 😻 |
Fixes #4965
-std=c++17
is failing withoutD_SILENCE_ALL_CXX17_DEPRECATION_WARNINGS
and-std=c++20
is not failing.I got the error:
--diag-error=128
I get:--diag-error=177
--diag-error=186
I didn't find how to enable all/almost all warnings with one command and if the warnings are good. We can enable three with
--diag-error=128,177,186
but I don't want to add string like this--diag-error=1,2,3,4,5,...,200
. And I found this:STL/stl/inc/string
Lines 459 to 469 in 1e312b3
So we took care about some nvcc warnings in the past...
typename
: https://gcc.godbolt.org/z/6TcboYYEe so I think the issue is fixed in CUDA 12.5.1, so we don't need to report upstream to Nvidia.