Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] change RuntimeIdentifier to win-xxx for .NET 8.0 -- fix issue #4717 #4723

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tonymet
Copy link

@tonymet tonymet commented Dec 11, 2023

PR checklist

Quick summary of changes
Fix .NET 8.0 specified RuntimeIdentifier 'win10-x64' is not recognized.

Full Error

NETSDK1083	The specified RuntimeIdentifier 'win10-x64' is not recognized. See https://aka.ms/netsdk1083 for more information.

More info: https://learn.microsoft.com/en-us/dotnet/core/compatibility/core-libraries/8.0/runtimeidentifier

Steps to Repeat

  1. Create new project from template
  2. Build Project

Which issue does this PR relate to?

#4717

Applies to the following platforms

  • [✅ ] WinUI
  • WPF
  • UWP

Anything that requires particular review or attention?

  • I could use help on how to perform e2e test with Template Studio using the updated template from this branch.
  • how to test this with earlier versions of .net e.g. .net 7 , .net 6
  • how to run automation on my own.

Do all automated tests pass?

✅ yes

Have automated tests been added for new features?
N/A

If you've changed the UI:
n/a

If you've included a new template:
n/a

Have you raised issues for any needed follow-on work?
n/a

Have docs been updated?
no

If breaking changes or different ways of doing things have been introduced, have they been communicated widely?

@tonymet tonymet changed the title [WIP] change RuntimeIdentifier to win-xxx [WIP] change RuntimeIdentifier to win-xxx for .NET 8.0 Dec 11, 2023
@tonymet tonymet changed the title [WIP] change RuntimeIdentifier to win-xxx for .NET 8.0 [WIP] change RuntimeIdentifier to win-xxx for .NET 8.0 -- fix issue #4717 Dec 12, 2023
@licon4812
Copy link

I was able to get this working locally by adding this to my csproj

<UseRidGraph>true</UseRidGraph>
<RuntimeIdentifiers>win10-x86;win10-x64;win10-arm64</RuntimeIdentifiers>

@pratikone
Copy link
Collaborator

Thahks for this. @licon4812 is correct. I am planning to use true for maximum backward compatibility for the next release. You can close this PR or change to use Rid

@tonymet
Copy link
Author

tonymet commented Mar 27, 2024

can you clarify? has it been fixed?

@pratikone
Copy link
Collaborator

pratikone commented Apr 4, 2024

not yet. I am suggesting to use <UseRidGraph>true</UseRidGraph> in your PR instead of win-x64 values so that it is backward compatible and then lets merge it
UseRidGraph>true</UseRidGraph>
<RuntimeIdentifiers>win10-x86;win10-x64;win10-arm64</RuntimeIdentifiers>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants