Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: New Event classes #235

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

MarcCote
Copy link
Contributor

This PR allows Events to be combined using boolean expressions (e.g. and/or). This is needed to make more complex quests.

This PR closes #218.

@MarcCote MarcCote requested a review from HakiRose May 21, 2020 01:55
Copy link
Contributor Author

@MarcCote MarcCote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HakiRose I've also added a bunch of tests. This PR doesn't contain your modifications for text_generation nor verb_tense.

textworld/generator/game.py Show resolved Hide resolved
textworld/generator/game.py Show resolved Hide resolved
textworld/generator/game.py Outdated Show resolved Hide resolved
textworld/generator/game.py Outdated Show resolved Hide resolved
textworld/generator/game.py Outdated Show resolved Hide resolved
textworld/generator/maker.py Show resolved Hide resolved
@MarcCote MarcCote force-pushed the New_event_style_v2 branch 2 times, most recently from 94a3fa1 to 866ce7d Compare May 21, 2020 02:56
@codecov-commenter
Copy link

codecov-commenter commented May 21, 2020

Codecov Report

Merging #235 (b2bda1a) into master (fd0d419) will decrease coverage by 1.55%.
The diff coverage is 92.51%.

❗ Current head b2bda1a differs from pull request most recent head ec5185b. Consider uploading reports for the commit ec5185b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #235      +/-   ##
==========================================
- Coverage   83.83%   82.28%   -1.56%     
==========================================
  Files          62       57       -5     
  Lines        7976     7839     -137     
==========================================
- Hits         6687     6450     -237     
- Misses       1289     1389     +100     
Impacted Files Coverage Δ
textworld/generator/maker.py 85.51% <77.94%> (-1.89%) ⬇️
textworld/generator/text_generation.py 84.13% <83.33%> (-0.15%) ⬇️
textworld/generator/inform7/world2inform7.py 90.04% <95.04%> (+0.01%) ⬆️
textworld/generator/game.py 92.50% <95.22%> (-2.27%) ⬇️
textworld/generator/__init__.py 95.48% <100.00%> (ø)
textworld/generator/logger.py 79.48% <100.00%> (ø)
textworld/challenges/tw_cooking/cooking.py 60.84% <0.00%> (-20.19%) ⬇️
textworld/gym/utils.py 83.33% <0.00%> (-16.67%) ⬇️
textworld/generator/data/__init__.py 78.02% <0.00%> (-1.57%) ⬇️
... and 13 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants