Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: add new requestable attributes to EnvInfos #347

Merged
merged 3 commits into from
Sep 28, 2024
Merged

ENH: add new requestable attributes to EnvInfos #347

merged 3 commits into from
Sep 28, 2024

Conversation

MarcCote
Copy link
Contributor

This PR allows the user to request the following new game information:

  • possible_commands: All possible commands regardless of the current state and the arguments type.
  • possible_admissible_commands: All possible commands regardless of the current state.
  • typed_entities: Names of all entities in the game and their type.

This PR also fixes an issue when loading directly the game .json file via textworld.start(...)

xingdi-eric-yuan
xingdi-eric-yuan previously approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@xingdi-eric-yuan xingdi-eric-yuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

textworld/generator/game.py Show resolved Hide resolved
@MarcCote MarcCote closed this Jun 20, 2024
@MarcCote MarcCote reopened this Jun 20, 2024
@MarcCote MarcCote force-pushed the enh_possible_commands branch 2 times, most recently from e64c020 to b392dc4 Compare July 24, 2024 20:44
@MarcCote MarcCote merged commit c1b959b into microsoft:main Sep 28, 2024
11 checks passed
@MarcCote MarcCote deleted the enh_possible_commands branch September 28, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xingdi-eric-yuan xingdi-eric-yuan xingdi-eric-yuan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcCote @xingdi-eric-yuan