Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve inline and google search results #1169

Merged
merged 3 commits into from
Sep 30, 2020
Merged

Improve inline and google search results #1169

merged 3 commits into from
Sep 30, 2020

Conversation

orta
Copy link
Contributor

@orta orta commented Sep 30, 2020

No description provided.

@@ -74,7 +74,7 @@ const TSConfigReferenceTemplateComponent = (props) => {

return (
<Layout title={i("tsconfig_title")} description={i("tsconfig_description")} lang={props.pageContext.locale} allSitePage={props.data.allSitePage}>
<div className="tsconfig raised main-content-block">
<div className="tsconfig raised main-content-block markdown">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


const { inlineTitle, compilerSettings } = getCompilerDetailsFromCode(code)
createPage({
path: newPagePath,
path: newPagePath + ".html",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prev: https://www.typescriptlang.org/ja/play/typescript/language-extensions/types-vs-interfaces.ts
Post: https://www.typescriptlang.org/ja/play/typescript/language-extensions/types-vs-interfaces.ts.html

I think it's safe to assume that search engines don't try read .ts or .js files.

@github-actions
Copy link
Contributor

Snapshots updated

backstop_default_TSConfig_Example_0_viewport_0_phone.png
Before After
backstop_default_TSConfig_Example_0_viewport_1_tablet.png
Before After
backstop_default_TSConfig_Example_0_viewport_2_computer.png
Before After

Generated by 🚫 dangerJS against 26210d6

@orta orta merged commit 5035c7e into v2 Sep 30, 2020
@orta orta mentioned this pull request Oct 19, 2020
@jakebailey jakebailey deleted the search_tsc branch May 17, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant