Fix: Prev Next Link incorrectly linking to "Nightly Builds" page by d… #3220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Currently, on many handbook pages, the "Previous" and "Next" link blocks at the bottom of the page incorrectly point to the "Nightly Builds" page by default when there should be no link at all.
For example:
Cause
This issue occurs due to the context variables
previousID
andnextID
being passed asundefined
when no relevant links are found.These variables are used in the eq filter here:
TypeScript-Website/packages/typescriptlang-org/src/templates/documentation.tsx
Line 269 in ac68b8b
The context variables are set here:
TypeScript-Website/packages/typescriptlang-org/lib/bootup/ingestion/createPagesForDocumentation.ts
Lines 120 to 121 in ac68b8b
Gatsby's graphql query explicitly only handles string, number, boolean and null values in
eq
. When undefined is passed, the filter gets ignored, which in this case results in the "Nightly Builds" page being linked by default.GraphQL explorer output:
When
undefined
is passedWhen
null
is passedSolution
This PR resolves the issue by setting the
previousID
andnextID
variables tonull
by default instead ofundefined
. If the next or previous page is found, these variables will be updated accordingly; otherwise, they remain null.Fixed handbook/intro.html: