Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing accessibility bug #3236

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Fixing accessibility bug #3236

merged 2 commits into from
Sep 30, 2024

Conversation

navya9singh
Copy link
Member

This pr fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2175667 and https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2175655. I've tested it out in both scenarios and this seems to solve the issue.

@jakebailey jakebailey added the deploy-preview Enables automatic deployments to preview environments on a PR label Sep 27, 2024
@jakebailey
Copy link
Member

Hiding the links on the right is designed behavior, as far as I know. Old:

image

New:

image

Is there no way to satisfy the report another way? I know some sites will instead put the aside on top or something...

@navya9singh
Copy link
Member Author

Is there no way to satisfy the report another way? I know some sites will instead put the aside on top or something...

Added some changes to make it put aside on top. How does this look?

@navya9singh navya9singh added deploy-preview Enables automatic deployments to preview environments on a PR and removed deploy-preview Enables automatic deployments to preview environments on a PR labels Sep 27, 2024
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-plant-05c166c10-3236.centralus.5.azurestaticapps.net

Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good!

@navya9singh navya9singh merged commit 89a0643 into v2 Sep 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy-preview Enables automatic deployments to preview environments on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants