Enable existing commit characters in certain locations where `isNewId…

…entifier` is true (#59523)
microsoft · Aug 19, 2024 · 1e7889c · 1e7889c
1 parent 936a79b
commit 1e7889c
Show file tree

Hide file tree

Showing 14 changed files with 91,403 additions and 55 deletions.
diff --git a/src/harness/fourslashImpl.ts b/src/harness/fourslashImpl.ts
@@ -1037,8 +1037,8 @@ export class TestState {
 
         if (ts.hasProperty(options, "defaultCommitCharacters")) {
             assert.deepEqual(
-                actualCompletions.defaultCommitCharacters?.sort(),
-                options.defaultCommitCharacters?.sort(),
+                actualCompletions.defaultCommitCharacters?.slice().sort(),
+                options.defaultCommitCharacters?.slice().sort(),
                 "Expected 'defaultCommitCharacters' properties to match",
             );
         }
@@ -1191,8 +1191,8 @@ export class TestState {
         assert.equal(actual.sortText, expected.sortText || ts.Completions.SortText.LocationPriority, `At entry ${actual.name}: Expected 'sortText' properties to match`);
         if (ts.hasProperty(expected, "commitCharacters")) {
             assert.deepEqual(
-                actual.commitCharacters?.sort(),
-                expected.commitCharacters?.sort(),
+                actual.commitCharacters?.slice().sort(),
+                expected.commitCharacters?.slice().sort(),
                 `At entry ${actual.name}: Expected 'commitCharacters' values to match`,
             );
         }

diff --git a/src/services/completions.ts b/src/services/completions.ts
diff --git a/tests/baselines/reference/completionsCommentsClassMembers.baseline b/tests/baselines/reference/completionsCommentsClassMembers.baseline
@@ -15330,7 +15330,11 @@
           ]
         }
       ],
-      "defaultCommitCharacters": []
+      "defaultCommitCharacters": [
+        ".",
+        ",",
+        ";"
+      ]
     }
   },
   {
@@ -27308,7 +27312,11 @@
           ]
         }
       ],
-      "defaultCommitCharacters": []
+      "defaultCommitCharacters": [
+        ".",
+        ",",
+        ";"
+      ]
     }
   },
   {
@@ -45958,7 +45966,11 @@
           ]
         }
       ],
-      "defaultCommitCharacters": []
+      "defaultCommitCharacters": [
+        ".",
+        ",",
+        ";"
+      ]
     }
   },
   {
@@ -56488,7 +56500,11 @@
           ]
         }
       ],
-      "defaultCommitCharacters": []
+      "defaultCommitCharacters": [
+        ".",
+        ",",
+        ";"
+      ]
     }
   },
   {
@@ -61751,7 +61767,11 @@
           ]
         }
       ],
-      "defaultCommitCharacters": []
+      "defaultCommitCharacters": [
+        ".",
+        ",",
+        ";"
+      ]
     }
   },
   {
@@ -69949,7 +69969,11 @@
           ]
         }
       ],
-      "defaultCommitCharacters": []
+      "defaultCommitCharacters": [
+        ".",
+        ",",
+        ";"
+      ]
     }
   },
   {
@@ -78147,7 +78171,11 @@
           ]
         }
       ],
-      "defaultCommitCharacters": []
+      "defaultCommitCharacters": [
+        ".",
+        ",",
+        ";"
+      ]
     }
   },
   {
@@ -86345,7 +86373,11 @@
           ]
         }
       ],
-      "defaultCommitCharacters": []
+      "defaultCommitCharacters": [
+        ".",
+        ",",
+        ";"
+      ]
     }
   },
   {
@@ -90932,7 +90964,11 @@
           ]
         }
       ],
-      "defaultCommitCharacters": []
+      "defaultCommitCharacters": [
+        ".",
+        ",",
+        ";"
+      ]
     }
   },
   {
@@ -100829,7 +100865,11 @@
           ]
         }
       ],
-      "defaultCommitCharacters": []
+      "defaultCommitCharacters": [
+        ".",
+        ",",
+        ";"
+      ]
     }
   }
 ]
diff --git a/tests/baselines/reference/completionsCommentsFunctionDeclaration.baseline b/tests/baselines/reference/completionsCommentsFunctionDeclaration.baseline
@@ -8290,7 +8290,11 @@
           ]
         }
       ],
-      "defaultCommitCharacters": []
+      "defaultCommitCharacters": [
+        ".",
+        ",",
+        ";"
+      ]
     }
   },
   {