Code review

microsoft · Mar 22, 2018 · e4f380c · e4f380c
1 parent 4dc9423
commit e4f380c
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 12 deletions.
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -314,16 +314,16 @@ namespace ts {
             getSuggestionDiagnostics: file => {
                 return (suggestionDiagnostics.get(file.fileName) || emptyArray).concat(getUnusedDiagnostics());
                 function getUnusedDiagnostics(): ReadonlyArray<Diagnostic> {
+                    if (file.isDeclarationFile) return emptyArray;
+
                     checkSourceFile(file);
                     const diagnostics: Diagnostic[] = [];
                     Debug.assert(!!(getNodeLinks(file).flags & NodeCheckFlags.TypeChecked));
-                    if (!file.isDeclarationFile) {
-                        checkUnusedIdentifiers(allPotentiallyUnusedIdentifiers.get(file.fileName)!, (kind, diag) => {
-                            if (!unusedIsError(kind)) {
-                                diagnostics.push({ ...diag, category: DiagnosticCategory.Suggestion });
-                            }
-                        });
-                    }
+                    checkUnusedIdentifiers(allPotentiallyUnusedIdentifiers.get(file.fileName)!, (kind, diag) => {
+                        if (!unusedIsError(kind)) {
+                            diagnostics.push({ ...diag, category: DiagnosticCategory.Suggestion });
+                        }
+                    });
                     return diagnostics;
                 }
             },

diff --git a/src/compiler/core.ts b/src/compiler/core.ts
@@ -1623,7 +1623,7 @@ namespace ts {
             messageText: text,
             category: message.category,
             code: message.code,
-            unused: message.unused,
+            reportsUnused: message.unused,
         };
     }
 
@@ -1654,7 +1654,7 @@ namespace ts {
             messageText: text,
             category: message.category,
             code: message.code,
-            unused: message.unused,
+            reportsUnused: message.unused,
         };
     }
 

diff --git a/src/compiler/types.ts b/src/compiler/types.ts
@@ -4061,7 +4061,7 @@ namespace ts {
         messageText: string | DiagnosticMessageChain;
         category: DiagnosticCategory;
         /** May store more in future. For now, this will simply be `true` to indicate when a diagnostic is an unused-identifier diagnostic. */
-        unused?: {};
+        reportsUnused?: {};
         code: number;
         source?: string;
     }

diff --git a/tests/baselines/reference/api/tsserverlibrary.d.ts b/tests/baselines/reference/api/tsserverlibrary.d.ts
@@ -2279,7 +2279,7 @@ declare namespace ts {
         messageText: string | DiagnosticMessageChain;
         category: DiagnosticCategory;
         /** May store more in future. For now, this will simply be `true` to indicate when a diagnostic is an unused-identifier diagnostic. */
-        unused?: {};
+        reportsUnused?: {};
         code: number;
         source?: string;
     }

diff --git a/tests/baselines/reference/api/typescript.d.ts b/tests/baselines/reference/api/typescript.d.ts
@@ -2279,7 +2279,7 @@ declare namespace ts {
         messageText: string | DiagnosticMessageChain;
         category: DiagnosticCategory;
         /** May store more in future. For now, this will simply be `true` to indicate when a diagnostic is an unused-identifier diagnostic. */
-        unused?: {};
+        reportsUnused?: {};
         code: number;
         source?: string;
     }