Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gulp runtests --test ge fails #10683

Closed
ghost opened this issue Sep 2, 2016 · 4 comments
Closed

gulp runtests --test ge fails #10683

ghost opened this issue Sep 2, 2016 · 4 comments
Assignees
Labels
Infrastructure Issue relates to TypeScript team infrastructure

Comments

@ghost
Copy link

ghost commented Sep 2, 2016

This also happens with runtests-browser, so I was able to get a sample error:

The first failing test is tests/cases/fourslash/shims/getEmitOutput.ts.
Error: The baseline file getEmitOutput.baseline has changed.

expected:

EmitSkipped: false
FileName : tests/cases/fourslash/shims/inputFile1.js
var x = 5;
var Bar = (function () {
    function Bar() {
    }
    return Bar;
}());
FileName : tests/cases/fourslash/shims/inputFile1.d.ts
declare var x: number;
declare class Bar {
    x: string;
    y: number;
}

EmitSkipped: false
FileName : tests/cases/fourslash/shims/inputFile2.js
var x1 = "hello world";
var Foo = (function () {
    function Foo() {
    }
    return Foo;
}());
FileName : tests/cases/fourslash/shims/inputFile2.d.ts
declare var x1: string;
declare class Foo {
    x: string;
    y: number;
}

Actual:

EmitSkipped: false
FileName : tests/cases/fourslash/inputFile1.js
var x = 5;
var Bar = (function () {
    function Bar() {
    }
    return Bar;
}());
FileName : tests/cases/fourslash/inputFile1.d.ts
declare var x: number;
declare class Bar {
    x: string;
    y: number;
}

EmitSkipped: false
FileName : tests/cases/fourslash/inputFile2.js
var x1 = "hello world";
var Foo = (function () {
    function Foo() {
    }
    return Foo;
}());
FileName : tests/cases/fourslash/inputFile2.d.ts
declare var x1: string;
declare class Foo {
    x: string;
    y: number;
}

Apparently the "shims" directory is disappearing from the output when we run the tests in this order.

@mhegazy mhegazy added the Infrastructure Issue relates to TypeScript team infrastructure label Sep 2, 2016
@ghost
Copy link
Author

ghost commented Jun 15, 2017

We also get test errors from running gulp runtests --test Resolution. Such as:

  618) Projects tests Compiling project for Visibility of type used across modules - 2: testcase tests/cases/project/visibilityOfTypeUsedAcrossModules2.json Resolution information of (amd): tests/cases/project/visibilityOfTypeUsedAcrossModules2.json:
     TypeError: Cannot read property 'moduleKind' of undefined
      at Context.<anonymous> (projectsRunner.ts:469:86)

@ghost
Copy link
Author

ghost commented Sep 6, 2017

gulp runtests --t format also results in a lot of errors.

...
  632) Projects tests Compiling project for Visibility of type used across modules - 2: testcase tests/cases/project/visibilityOfTypeUsedAcrossModules2.json Resolution information of (amd): tests/cases/project/visibilityOfTypeUsedAcrossModules2.json:
     TypeError: Cannot read property 'moduleKind' of undefined
      at Context.<anonymous> (src/harness/projectsRunner.ts:468:86)

Also gulp runtests --t emit and gulp runtests --t info and gulp runtests --t enerat.

@ghost
Copy link
Author

ghost commented Jun 15, 2018

@RyanCavanaugh There's a recent example of this -- running jake runtests t=ode fails in a tsbuild test which is apparently stateful.

@weswigham
Copy link
Member

None of the given examples cause failures anymore ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issue relates to TypeScript team infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants