getScriptInfoOrConfig: Canonicalize tsconfig path before lookup #26280
Conversation
ghost
force-pushed
the
tsconfig_canonicalpath
branch
from
af2dfe9
to
a06fcb7
Compare
|
The error in travis has no stacktrace and doesn't occur when I run the test myself... |
ghost
force-pushed
the
tsconfig_canonicalpath
branch
from
a06fcb7
to
77494d6
Compare
|
Ran |
src/server/editorServices.ts
Outdated
| @@ -1804,7 +1804,7 @@ namespace ts.server { | |||
| const path = toNormalizedPath(uncheckedFileName); | |||
| const info = this.getScriptInfoForNormalizedPath(path); | |||
| if (info) return info; | |||
| const configProject = this.configuredProjects.get(uncheckedFileName); | |||
| const configProject = this.configuredProjects.get(this.toCanonicalFileName(uncheckedFileName)); | |||
There was a problem hiding this comment.
I don't think this is right infact you want to use 'path' here as the key I think.
There was a problem hiding this comment.
It looks like I still at least need this.toCanonicalFileName(path). The key comes from project.canonicalConfigPath which is asNormalizedPath(projectService.toCanonicalFileName(configFileName));
|
@RyanCavanaugh Any guess what might be going on here? The error is |
src/server/editorServices.ts
Outdated
| @@ -1884,7 +1884,7 @@ namespace ts.server { | |||
| const path = toNormalizedPath(uncheckedFileName); | |||
| const info = this.getScriptInfoForNormalizedPath(path); | |||
| if (info) return info; | |||
| const configProject = this.configuredProjects.get(uncheckedFileName); | |||
| const configProject = this.configuredProjects.get(this.toCanonicalFileName(path)); | |||
There was a problem hiding this comment.
This should this.toPath(uncheckedFileName) instead of just canonicalizing file name, (you need to handle current directory as well though in most cases unchecked file is absolute path but toPath is more correct version)
ghost
assigned 
May fix the remaining issue in #24857