Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to detect semantic only blockers vs. emit blockers #2289

Closed
basarat opened this issue Mar 10, 2015 · 3 comments
Closed

How to detect semantic only blockers vs. emit blockers #2289

basarat opened this issue Mar 10, 2015 · 3 comments
Labels
Question An issue which isn't directly actionable in code

Comments

@basarat
Copy link
Contributor

basarat commented Mar 10, 2015

Previously we had:

success : output.emitOutputStatus === ts.EmitReturnStatus.Succeeded;
emitOnly: !success && outputFiles.length

Now getEmitOutput only returns :

interface EmitOutput {
    outputFiles: OutputFile[];
    emitSkipped: boolean;
}

With only emitSkipped we don't know if it was a complete success i.e. a semantically valid emit or just a bland best attempt emit.

@DanielRosenwasser
Copy link
Member

Somewhat unfortunately, we don't have the distinction between syntactic and semantic errors in the compiler anymore.

@basarat
Copy link
Contributor Author

basarat commented Mar 11, 2015

@basarat basarat closed this as completed Mar 11, 2015
@basarat
Copy link
Contributor Author

basarat commented Mar 11, 2015

@DanielRosenwasser would be great if you can look at #2290

@mhegazy mhegazy added the Question An issue which isn't directly actionable in code label Mar 11, 2015
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Question An issue which isn't directly actionable in code
Projects
None yet
Development

No branches or pull requests

3 participants