Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Struggling to get an emit failure with 1.5 #2290

Closed
basarat opened this issue Mar 10, 2015 · 5 comments
Closed

Struggling to get an emit failure with 1.5 #2290

basarat opened this issue Mar 10, 2015 · 5 comments
Labels
Question An issue which isn't directly actionable in code

Comments

@basarat
Copy link
Contributor

basarat commented Mar 10, 2015

Previously the following would fail to emit due to parsing errors:

var foo = 123 123;

Now it does emit JS:

var foo = 123;
123;

What's more is that something crazy like:

2nof234@#$@#$&3421834701234!@#$!&@#$"!H#@$LK!N@#LSOD*F&(O@#*$&@#$1)"YH!@#$(O*&!@#$)

does an js emit:

2;
nof234;
$;
$ & 3421834701234;
!;
$;
! & ;
$;
"!H#@$LK!N@#LSOD*F&(O@#*$&@#$1)";
YH;
!;
$(O *  & !, $);

Are you guys aware of anything that will block an emit now? I just want this for a test ❤️

refs : TypeStrong/atom-typescript#179

@danquirk danquirk added the Question An issue which isn't directly actionable in code label Mar 11, 2015
@danquirk
Copy link
Member

Maybe relevant is #1527 and #1421

@mhegazy
Copy link
Contributor

mhegazy commented Mar 11, 2015

Previously we blocked emit in the face of early errors. it was getting a bit arbitrary what is early and what is not, in #1527 we have relaxed this restriction, and now we emit even with errors.
You can always use the --noEmitOnError to avoid emit with errors.

@basarat
Copy link
Contributor Author

basarat commented Mar 11, 2015

and now we emit even with errors

So with noEmitOnError switched off we will always emit? is my understanding correct

@mhegazy
Copy link
Contributor

mhegazy commented Mar 11, 2015

For JavaScript/source maps yes. we will always emit. for declarations, we currently have a check on errors. we are still talking about this part, whether to block declaration emit on errors (current behavior) or enable it as well.

@basarat
Copy link
Contributor Author

basarat commented Mar 11, 2015

Thank you. That answers all my queries ❤️

@basarat basarat closed this as completed Mar 11, 2015
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Question An issue which isn't directly actionable in code
Projects
None yet
Development

No branches or pull requests

3 participants