Allow a path mapping to provide a file extension #12103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
ghost
force-pushed
the
path_mapping_exact_extension
branch
from
299e85f
to
1c64615
Compare
vladima
reviewed
Nov 11, 2016
| if (resolved) { | ||
| return resolved; | ||
| // A path mapping may have a ".ts" extension; in contrast to an import, which should omit it. | ||
| const tsExtension = tryGetTypeScriptExtensionFromPath(candidate); |
There was a problem hiding this comment.
I don't think that restricting extensions to only .ts is a right thing here i.e. if user wants to remap some import to .js file. (cc @mhegazy for the opinion)
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12098