Fix elided syntax kinds falling through to visitConstructor in TypeScript transformer #12639
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TypeScript transformer elides a bunch of syntax kinds that should not appear in the emitted JavaScript code (e.g. access modifiers, types,...). Normally, this elision would be done by returning
undefined
from the visitor.This commit changed the handling for
SyntaxKind.Constructor
: previously constructors were elided, but nowvisitConstructor
handles them. However, the commit forgot to stop the cases above theSyntaxKind.Constructor
case falling through, so now all cases that should just havereturn undefined
actually callvisitConstructor
instead. Luckily,visitConstructor
returnsundefined
when its argument is not a function-like declaration, which is why the code works and passes the tests... although it works for the wrong reason. 😛This change re-introduces the missing
return undefined
statement, so the elided cases no longer fall through tovisitConstructor
.