Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Master] Type checking JSX children #15160

Merged
merged 24 commits into from
Apr 21, 2017
Merged

[Master] Type checking JSX children #15160

merged 24 commits into from
Apr 21, 2017

Commits on Apr 7, 2017

  1. Wip - type checking JSX children

    Kanchalai Tanglertsampan committed Apr 7, 2017
    Configuration menu
    Copy the full SHA
    b3846bf View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2017

  1. Consider whitespace that won't be emitted to be different kind so tha… 

    …t we won't include in typ-checking
    Kanchalai Tanglertsampan committed Apr 11, 2017
    Configuration menu
    Copy the full SHA
    f86a730 View commit details
    Browse the repository at this point in the history

  2. Use JSX Attributes to contextually type children property

    Kanchalai Tanglertsampan committed Apr 11, 2017
    Configuration menu
    Copy the full SHA
    8e2dd38 View commit details
    Browse the repository at this point in the history

  3. Format checker

    Kanchalai Tanglertsampan committed Apr 11, 2017
    Configuration menu
    Copy the full SHA
    17417e9 View commit details
    Browse the repository at this point in the history

  4. Store scanning information whether JSXText is just an all whitespaces

    Kanchalai Tanglertsampan committed Apr 11, 2017
    Configuration menu
    Copy the full SHA
    4562fd0 View commit details
    Browse the repository at this point in the history

  5. wip-fixing consuming whitespace in children

    Kanchalai Tanglertsampan committed Apr 11, 2017
    Configuration menu
    Copy the full SHA
    c1ea303 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2017

  1. Fixing consuming whitespace in children

    Kanchalai Tanglertsampan committed Apr 12, 2017
    Configuration menu
    Copy the full SHA
    4fa2312 View commit details
    Browse the repository at this point in the history

  2. Add tests

    Kanchalai Tanglertsampan committed Apr 12, 2017
    Configuration menu
    Copy the full SHA
    f099046 View commit details
    Browse the repository at this point in the history

  3. update baselines

    Kanchalai Tanglertsampan committed Apr 12, 2017
    Configuration menu
    Copy the full SHA
    eb0ad7f View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master-jsxChildren' of https://github.com/Microsoft/Typ… 

    …eScript into master-jsxChildren

# Conflicts:
#	src/compiler/scanner.ts
    Kanchalai Tanglertsampan committed Apr 12, 2017
    Configuration menu
    Copy the full SHA
    e5b95fc View commit details
    Browse the repository at this point in the history

  5. Fix linting error

    Kanchalai Tanglertsampan committed Apr 12, 2017
    Configuration menu
    Copy the full SHA
    012f459 View commit details
    Browse the repository at this point in the history

  6. Add tests and update baselines

    Kanchalai Tanglertsampan committed Apr 12, 2017
    Configuration menu
    Copy the full SHA
    58e2189 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2017

  1. Remove a flag indicating the children is synthesized..We will give an… 

    … error if you use children without specified such property
    Kanchalai Tanglertsampan committed Apr 14, 2017
    Configuration menu
    Copy the full SHA
    bb8bab3 View commit details
    Browse the repository at this point in the history

  2. Read "children" property from react DTS file

    Kanchalai Tanglertsampan committed Apr 14, 2017
    Configuration menu
    Copy the full SHA
    c778a48 View commit details
    Browse the repository at this point in the history

  3. Update tests and baselines

    Kanchalai Tanglertsampan committed Apr 14, 2017
    Configuration menu
    Copy the full SHA
    dbf2a96 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2017

  1. Update baselines and tests (2)

    Kanchalai Tanglertsampan committed Apr 17, 2017
    Configuration menu
    Copy the full SHA
    9a23b75 View commit details
    Browse the repository at this point in the history

  2. Fix linting error

    Kanchalai Tanglertsampan committed Apr 17, 2017
    Configuration menu
    Copy the full SHA
    7829cba View commit details
    Browse the repository at this point in the history

  3. Update error message to use variable name for "children"

    Kanchalai Tanglertsampan committed Apr 17, 2017
    Configuration menu
    Copy the full SHA
    d290cf7 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into master-jsxChildren 

    # Conflicts:
#	src/compiler/checker.ts
#	src/compiler/diagnosticMessages.json
    Kanchalai Tanglertsampan committed Apr 17, 2017
    Configuration menu
    Copy the full SHA
    f6f0813 View commit details
    Browse the repository at this point in the history

  5. Fix baselines and linting error from merging with master

    Kanchalai Tanglertsampan committed Apr 17, 2017
    Configuration menu
    Copy the full SHA
    c13383a View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2017

  1. Change how we look up children attribute from react.d.ts

    Yui T committed Apr 20, 2017
    Configuration menu
    Copy the full SHA
    e9cd3ad View commit details
    Browse the repository at this point in the history

  2. Update tests and baselines

    Yui T committed Apr 20, 2017
    Configuration menu
    Copy the full SHA
    b7a30c1 View commit details
    Browse the repository at this point in the history

  3. Fix spelling and add comment

    Yui T committed Apr 20, 2017
    Configuration menu
    Copy the full SHA
    e03be45 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2017

  1. Fix linting

    Kanchalai Tanglertsampan committed Apr 21, 2017
    Configuration menu
    Copy the full SHA
    e7e13ec View commit details
    Browse the repository at this point in the history