Support quick info at function and => locations
#19669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhegazy
reviewed
Nov 1, 2017
| @@ -489,8 +489,10 @@ namespace ts.SymbolDisplay { | |||
| addNewLineIfDisplayPartsExist(); | |||
| if (symbolKind) { | |||
| pushTypePart(symbolKind); | |||
| displayParts.push(spacePart()); | |||
| addFullSymbolName(symbol); | |||
| if (!some(symbol.declarations, d => isArrowFunction(d) || (isFunctionExpression(d) || isClassExpression(d)) && !d.name)) { | |||
There was a problem hiding this comment.
A few declarations don't have a name property but will still have a name when written out by the checker.
|
Shouldn't there be a change to getQuickInfoAtPoisiton to allow for |
mhegazy
approved these changes
Nov 2, 2017
ghost
force-pushed
the
quickInfoFunctionKeyword
branch
from
53b15bb
to
f98e56d
Compare
ghost
force-pushed
the
quickInfoFunctionKeyword
branch
from
f98e56d
to
33ace79
Compare
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2736
I think this would be better-looking if we stopped writing
(local function)and just usedfunction, although that was apparently intentional at some point and would change a lot of baselines.