Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle arrays with properties in assert.deepEqual #20674

Merged
2 commits merged into from
Dec 13, 2017
Merged

Handle arrays with properties in assert.deepEqual #20674

2 commits merged into from
Dec 13, 2017

Conversation

ghost
Copy link

@ghost ghost commented Dec 13, 2017

Porting a fix from #20429

@ghost
Copy link
Author

ghost commented Dec 13, 2017 •
edited by ghost
Loading

Now that we're testing for this, had to change a few tests to use assert.lengthOf( instead of assert.deepEqual(emptyArray; a real fix for that is #20518.

@ghost ghost requested a review from weswigham December 13, 2017 17:09
weswigham
weswigham approved these changes Dec 13, 2017
View reviewed changes
Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels a tad unfortunate to do it this way (the deep equal library exposes an options object where you can pass in a comparator, so it could be handled that way), but I guess it's better for this behavior to be the default.

@ghost ghost merged commit 84eb25c into master Dec 13, 2017
@ghost ghost deleted the deepEqual branch December 13, 2017 19:50
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@weswigham