Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ReadonlyArray overload to Array.isArray #28916

Closed
wants to merge 7 commits into from
Closed

Add ReadonlyArray overload to Array.isArray #28916

wants to merge 7 commits into from

Commits on Dec 8, 2018

  1. Add ReadonlyArray overload for Array.isArray()

    @ulrichb
    ulrichb committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    ef70c04 View commit details
    Browse the repository at this point in the history

  2. Accept remaining baselines

    @ulrichb
    ulrichb committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    f02bdcb View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2019

  1. Merge remote-tracking branch 'origin/master' into IsArrayReadonlyArra… 

    …yOverload

# Conflicts:
#	tests/baselines/reference/destructuringParameterDeclaration4.errors.txt
#	tests/baselines/reference/promisePermutations.errors.txt
#	tests/baselines/reference/promisePermutations2.errors.txt
#	tests/baselines/reference/promisePermutations3.errors.txt
#	tests/baselines/reference/promiseTypeInference.errors.txt
    @ulrichb
    ulrichb committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    659e901 View commit details
    Browse the repository at this point in the history

  2. Switch to alternative which uses conditional types instead of an over… 

    …load for 'isArray'

This has the advantage that it upcasts non-array inputs to Array<any> instead of ReadonlyArray<any> (=> no breaking change in this case).
    @ulrichb
    ulrichb committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    57fa898 View commit details
    Browse the repository at this point in the history

  3. Use parameters instead of casting of test types

    @ulrichb
    ulrichb committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    93e902d View commit details
    Browse the repository at this point in the history

  4. Add additional negative tests

    @ulrichb
    ulrichb committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    5e54de0 View commit details
    Browse the repository at this point in the history

  5. Fix leftover test type cast

    @ulrichb
    ulrichb committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    88cd932 View commit details
    Browse the repository at this point in the history