Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --noEmitHelpers flag #2901

Merged
merged 1 commit into from
May 1, 2015
Merged

Add support for --noEmitHelpers flag #2901

merged 1 commit into from
May 1, 2015

Commits on Apr 30, 2015

  1. Add support for --noEmitHelpers flag

    This PR is a Work In Progress that addresses multiple `__extends`
    being output as described in #1350: Multiple `__extends` being output
    when `--module amd` is set.
    
    The issue still exists as of `v1.5.0 - f53e6a8`.
    
    Apparently a fix was created for this in #1356 but according to #2009, a
    [comment](#2009 (comment))
    later indicated that this was never merged in.
    
    Further conversation continued in #2487 but did not yield any result. I
    refer to my earlier recommendation in #1350.
    
    > My question is this, would the TypeScript team be open to a flag that
    > can be passed to tsc that will generate something like the following
    > ```ts
    > define(["require", "exports", "__extends", './mammal'], function (require, exports, __extends, Mammal) {
    >     var Human = (function (_super) {
    >         __extends(Human, _super);
    >         function Human() {
    >             _super.apply(this, arguments);
    >         }
    >         return Human;
    >     })(Mammal);
    >     return Human;
    > });
    > ```
    
    To continue with the naming convention I have chosen the flag
    `--noEmitHelpers`.
    James Whitney committed Apr 30, 2015
    Configuration menu
    Copy the full SHA
    76fa4b8 View commit details
    Browse the repository at this point in the history