🤖 User test baselines have changed #31034
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
force-pushed
the
user-update-Microsoft-20190305
branch
from
002e4d1
to
8d61fff
Compare
sandersn
reviewed
Apr 19, 2019
| @@ -0,0 +1,12 @@ | |||
| Exit Code: 1 | |||
| Standard output: | |||
| node_modules/soap/lib/client.d.ts(4,26): error TS7016: Could not find a declaration file for module 'request'. '../../../tests/cases/user/soap/node_modules/request/index.js' implicitly has an 'any' type. | |||
There was a problem hiding this comment.
they upgraded to typescript, but not to --strict, so we're seeing an error that they are not.
There was a problem hiding this comment.
I'm not sure what the correct fix is here — it looks to me like they need @types/request in their dependencies, not just devDependencies. Opinions @RyanCavanaugh or @weswigham ?
There was a problem hiding this comment.
dependencies - it's the only way to get npm i to install transitive dependencies for consumers (reasonably).
| @@ -8,105 +8,105 @@ node_modules/uglify-js/lib/ast.js(870,14): error TS2339: Property 'push' does no | |||
| node_modules/uglify-js/lib/ast.js(877,14): error TS2339: Property 'pop' does not exist on type 'TreeWalker'. | |||
| node_modules/uglify-js/lib/ast.js(932,25): error TS2339: Property 'self' does not exist on type 'TreeWalker'. | |||
| node_modules/uglify-js/lib/ast.js(933,37): error TS2339: Property 'parent' does not exist on type 'TreeWalker'. | |||
| node_modules/uglify-js/lib/compress.js(174,42): error TS2554: Expected 0 arguments, but got 1. | |||
|
Opened vpulim/node-soap#1059 |
typescript-bot
force-pushed
the
user-update-Microsoft-20190305
branch
from
8d61fff
to
7908904
Compare
typescript-bot
force-pushed
the
user-update-Microsoft-20190305
branch
from
7908904
to
60e8124
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @weswigham @sandersn @RyanCavanaugh