Use related error spans for "implement abstract class" errors #35076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
crc442
reviewed
Nov 21, 2019
| !!! error TS2515: Non-abstract class 'C' does not implement inherited abstract member 'prop' from class 'B'. | ||
| ~ | ||
| !!! error TS2515: Non-abstract class 'C' does not implement inherited abstract member 'readonlyProp' from class 'B'. | ||
| !!! error TS2515: Non-abstract class 'C' does not implement inherited abstract member 'm' from class 'B'. |
There was a problem hiding this comment.
this is what I was implementing towards
!!! error TS<NEWCODE>: Non-abstract class 'C' does not implement every abstract members of class 'B'
!!! error TS<NEWCODE>: Class 'C' is missing the following member implementations from class 'B': prop, readonlyprop, m
- new generic error with details in span
There was a problem hiding this comment.
But if this implementation works for us, I'll stop what I am doing; else I should be able to finish in a day or two
There was a problem hiding this comment.
I think your message is more suitable for the proposal.
Proposal
Instead of generating two errors in this case, generate a single, generic diagnostic that states > something like: B does not implement all abstract members of A and on that diagnostic return > related spans that state specifically which members are not implemented (b and c).
Please let us know your worked branch and let's ask to @DanielRosenwasser
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32848
I combine messages using chainDiagnosticMessages.
But I cannot sure this is really good.
Can you give me some opinion?
cc @DanielRosenwasser @mjbvz @crc442