Completion list show correct entry for function expression and class expression #3643
Conversation
| // fo$ <- completion list should contain local name "foo" | ||
| // } | ||
| // foo$ <- completion list should not contain "foo" | ||
| if (displayName === "__function" || displayName === "__class") { |
There was a problem hiding this comment.
Look into getDeclaredName instead, including the above for the default export
There was a problem hiding this comment.
getDeclaredName doesn't handle function expression correctly. Talk with @mhegazy, the function needed some rewrite and I don't want to have it done in this PR. I will put a TODO here to have it change once getDeclaredName is done
There was a problem hiding this comment.
@DanielRosenwasser should have a fix for this in a pending review. you should synchronize.
There was a problem hiding this comment.
Ah right, it's in my PR. Speaking of which, can you guys review it? 😃
#3367
There was a problem hiding this comment.
You should be clear to use getDeclaredName
| @@ -1423,6 +1423,9 @@ namespace ts { | |||
| // class X {} | |||
| export const classElement = "class"; | |||
|
|
|||
| // var x = class X {} | |||
| export const localClassElement = "local class"; | |||
|
|
|||
There was a problem hiding this comment.
note. you need to handle this on the managed side as well.
There was a problem hiding this comment.
What you mean be handling in the managed side?
There was a problem hiding this comment.
Probably best to discuss this in person with someone but I believe the idea is that VS needs to handle styles differently depending on what comes in to the managed side.
There was a problem hiding this comment.
what do you see in navbar when you do this?
|
@yuit if you pull in from |
…with certain kind, document, and text is the completion list
| // The reason we are not using copySymbol for function expression and class expression | ||
| // is that copySymbol will not copy a symbol into SymbolTable if the symbol has name prefix | ||
| // with "__". Therefore, if class expression or function expression have declared name, | ||
| // we will add the symbol into the table using its declared name |
There was a problem hiding this comment.
Why not change the logic of copySymbol?
Also, the comment for copySymbol says // Returns 'true' if we should stop processing symbols., but it returns void. Can you fix that?
Conflicts: src/compiler/checker.ts
| if (length >= 2 && name.charCodeAt(0) === CharacterCodes.doubleQuote && name.charCodeAt(length - 1) === CharacterCodes.doubleQuote) { | ||
| if (length >= 2 && | ||
| name.charCodeAt(0) === name.charCodeAt(length - 1) && | ||
| (name.charCodeAt(0) === CharacterCodes.doubleQuote || name.charCodeAt(0) === CharacterCodes.singleQuote)) { |
Conflicts: tests/cases/fourslash/renameLocationsForClassExpression01.ts
…t now correctly represent declared-name.
| if (!(memberFlags & NodeFlags.Static)) { | ||
| copySymbols(getSymbolOfNode(location).members, meaning & SymbolFlags.Type); | ||
| } | ||
| break; | ||
| case SyntaxKind.FunctionExpression: | ||
| if ((<FunctionExpression>location).name) { | ||
| case SyntaxKind.ClassExpression: |
There was a problem hiding this comment.
class expression listed twice
There was a problem hiding this comment.
Uh oh. It'd be good to have a feature that catches this.
There was a problem hiding this comment.
@JsonFreeman it's being tracked in #2854
|
👍 just remove the class expression label |
|
@yuit Do you still need to do all these things now that you fixed the binder? |
|
@JsonFreeman I make a change so that the service layer will get name through |
|
Great! Thanks Yui! |
|
👍 |
|
@JsonFreeman Thank you for the good discussion we had 😄 |
… completionListWithLocalName
Completion list show correct entry for function expression and class expression
Fix #3231 and for class expression case