-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for pedantic property access #40171
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions for the wording of messages.
Also, at the Friday (Sep 4) design meeting, we decided not to create a single naming scheme for pedantic options, but (1) to name them for what they do (2) use the "no-" prefix only if it makes sense, since we already have some pedantic options named that, like noUnusedLocals, noFallthroughCasesInSwitch, etc. I would suggest noPropertyAccessFromIndexSignature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks good, @sandersn’s messaging suggestions look good
Really useful and awaited! :) |
@ssledorze After 4.1 release, I guess. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge this after 4.1 RC.
should I understand it will be in the 4.1 release @sandersn ? |
No, we're finishing up 4.1 RC right now, then 4.1 will get its own branch. After that, commits to master will go into 4.2. So this will be in 4.2. |
@typescript-bot pack this. |
Hey @Kingwl, I've packed this into an installable tgz. You can install it for testing by referencing it in your
and then running There is also a playground for this build. |
The TypeScript team hasn't accepted the linked issue #40170. This makes it less likely that we'll review or accept this PR. Try to get the originating issue accepted. |
Fixes #40170