-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert assignability cases in getNarrowedType #42231
Revert assignability cases in getNarrowedType #42231
Conversation
All of those reports seem to involve |
I think this still triggers odd outcomes:
|
@typescript-bot pack this |
Heya @orta, I've started to run the perf test suite on this PR at 21d55ad. You can monitor the build here. Update: The results are in! |
Hey @orta, I've packed this into an installable tgz. You can install it for testing by referencing it in your
and then running There is also a playground for this build and an npm module you can use via |
@orta Here they are:Comparison Report - master..42231
System
Hosts
Scenarios
|
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
I'm heading out for the night, not sure if getting Anders' sign off is a blocker, if it's not can one of you two merge? |
Thanks @orta! |
Added in #39258 - which caused too many breaks to ship, then skipped in #41849 as the assignability narrowing might still be valuable. However, we've got enough reports that this is probably worth dropping too.
re: #42225 - #41808 #41984