Ensure that when new file affecting global scope is added, the signatures are updated #43084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
sheetalkamat
requested review from
sandersn,
amcasey,
andrewbranch and
RyanCavanaugh
sokra
reviewed
Mar 5, 2021
| cancellationToken, | ||
| computeHash, | ||
| state.currentAffectedFilesExportedModulesMap | ||
| ); |
There was a problem hiding this comment.
Once merged with #42960 this has to be added here:
/*avoidInitializingSignatures*/ true
amcasey
reviewed
Mar 9, 2021
sheetalkamat
commented
Mar 9, 2021
amcasey
approved these changes
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while working on #41004 and since this will be also affected by #42960 good idea to get this in before these two