Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reducing tsbuildinfo size further #43695

Merged
merged 4 commits into from
Apr 17, 2021
Merged

Reducing tsbuildinfo size further #43695

merged 4 commits into from
Apr 17, 2021

Conversation

sheetalkamat
Copy link
Member

@sheetalkamat sheetalkamat commented Apr 15, 2021

Here are the numbers with one of the internal tsbuildinfo
4de704d Only emit compiler options that affect

04/15/2021  01:26 PM           670,576 infoNew.json
04/15/2021  01:26 PM         1,023,762 infoOriginal.json

a422f9e: Dont emit affectsGlobalScope if its not true

04/15/2021  01:38 PM           612,256 infoNew.json
04/15/2021  01:38 PM         1,023,762 infoOriginal.json

658587d: FileInfo is encoded as string if FileInfo.version === FileInfo.signature && !FileInfo.affectsGlobalScope, otherwise property signature is encoded as false if it was undefined, undefined if FileInfo.version === FileInfo.signature and actual signature otherwise

04/15/2021  03:47 PM           410,798 infoNew.json
04/15/2021  03:47 PM         1,023,762 infoOriginal.json

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Apr 15, 2021
@sheetalkamat sheetalkamat marked this pull request as ready for review April 15, 2021 23:14
Copy link
Member

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just measuring against the motivating code base (ETA one hour).

src/compiler/builder.ts Outdated Show resolved Hide resolved
@amcasey
Copy link
Member

amcasey commented Apr 16, 2021

tsbuildinfo size dropped from 1345MB to 467MB and total build time dropped ~15%. 🎉

src/compiler/builder.ts Outdated Show resolved Hide resolved
@sheetalkamat sheetalkamat merged commit 01264ac into master Apr 17, 2021
@sheetalkamat sheetalkamat deleted the tsbuildInfoOptions branch April 17, 2021 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants