Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support parser of record and tuple #45546

Closed

Conversation

Jack-Works
Copy link
Contributor

close #39831

  • Parser
  • Add global Record, Tuple, Box constructor
  • Type check
  • Emitter (No plan to work on the emitter like what TypeScript did on BigInt).
  • Add tests
  • Add box unwrap on completion
  • Add box wrapper on completion

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Aug 23, 2021
@typescript-bot
Copy link
Collaborator

The TypeScript team hasn't accepted the linked issue #39831. If you can get it accepted, this PR will have a better chance of being reviewed.

@DanielRosenwasser
Copy link
Member

Hey @Jack-Works, thanks for the PR. This feature is something that has pretty deep type system implications and I think it's something the core team needs to spend some time on discussing the finer details. You're obviously free to continue iterating, but I think we want to give a fair bit of warning that what ends up here might diverge drastically from the design we arrive at, and we may end up creating a separate pull request if those changes are very involved.

@Jack-Works
Copy link
Contributor Author

Okay, so I may stop at the parser and very simple type integration. Is that ok? Or I can wait for the official design. @DanielRosenwasser

@DanielRosenwasser
Copy link
Member

Sorry I didn't see the above comment. We're open to experiments and understanding issues/constraints that you run into, but from our most recent design meeting it really seemed like others would be more comfortable with a PR that comes from the core team because of the scope of the feature.

@Jack-Works
Copy link
Contributor Author

hope the official team can support this quick after it reach stage 3 or 4 👀

@Jack-Works Jack-Works closed this Mar 27, 2022
@Jack-Works Jack-Works deleted the proposal-record-and-tuple branch March 27, 2022 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proposal-record-tuple
3 participants