Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed replacement from jsx completions #46767

Merged
merged 2 commits into from
Nov 11, 2021

Conversation

armanio123
Copy link
Member

@armanio123 armanio123 commented Nov 11, 2021

Fixes #46704 and vscode#136377

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Nov 11, 2021
@andrewbranch
Copy link
Member

@typescript-bot cherry-pick this to release-4.5 🍒

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 11, 2021

Heya @andrewbranch, I've started to run the task to cherry-pick this into release-4.5 on this PR at 20c24b9. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

Hey @andrewbranch, I've opened #46769 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Nov 11, 2021
Component commits:
1c07983 Removed replacement from jsx completions

20c24b9 Fixed tests
@armanio123 armanio123 merged commit 7b86a65 into microsoft:main Nov 11, 2021
andrewbranch pushed a commit that referenced this pull request Nov 11, 2021
Component commits:
1c07983 Removed replacement from jsx completions

20c24b9 Fixed tests

Co-authored-by: Armando Aguirre <[email protected]>
mprobst pushed a commit to mprobst/TypeScript that referenced this pull request Jan 10, 2022
* Removed replacement from jsx completions

* Fixed tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sometimes when using JSX Tag completion, the trailing tag termination character disappears
3 participants