fix(7410): Support JSX Element as JSX Attribute Value #47994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanCavanaugh
approved these changes
Mar 2, 2022
|
Waiting for final confirmation on facebook/jsx#53 before merging/closing. |
j-f1
reviewed
Mar 2, 2022
raghavthind2005
approved these changes
Mar 15, 2022
|
@raghavthind2005 bulk-"approving" changes like what you're doing here is a little spammy; please refrain from doing this |
|
@RyanCavanaugh are we still waiting on confirmation from facebook/jsx to merge this? |
|
Maybe let's just merge it. If the JSX spec changes, we'll have the same mess to clean up as Babel, which is fine |
This was referenced May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7410
JSXAttributeValue: " JSXDoubleStringCharactersopt " ' JSXSingleStringCharactersopt ' { AssignmentExpression } JSXElement JSXFragment