Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix export = error message to not have redundant language #50308

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

jakebailey
Copy link
Member

I noticed this while working on a project this weekend; this message currently says:

This module is declared with using 'export ='

"with using" is sorta like typoing "is is". I removed "using" so it's not duplicated, but that's just a wording taste.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Aug 15, 2022
@jakebailey jakebailey merged commit fd3c46b into microsoft:main Aug 15, 2022
@jakebailey jakebailey deleted the fix-module-decl-error branch August 15, 2022 20:13
@weswigham
Copy link
Member

@typescript-bot cherry-pick this into release-4.8

Prereq of #49814 merging into 4.8

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 31, 2022

Heya @weswigham, I've started to run the task to cherry-pick this into release-4.8 on this PR at 5392e26. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

Hey @weswigham, I've opened #50577 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Sep 1, 2022
Component commits:
5392e26 Fix export = error message to not have redundant language
weswigham pushed a commit that referenced this pull request Sep 1, 2022
Component commits:
5392e26 Fix export = error message to not have redundant language

Co-authored-by: Jake Bailey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants