-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove webServer #51699
Remove webServer #51699
Conversation
First draft; I may move some things around to be more readable.
1. Move StartSessionOptions to common next to where it's first used. 2. Inline single-use BaseLogger base class into its only child class, Logger. 3. Start using direct imports, eg `import {} from './common'`. I hope this is OK?!
@jakebailey The most recent commit removes |
( Not that it's too important as the URLs are hidden, but it might be worth checking if you need to write an issue on vscode-web to remove the vscode-ts-playground code which relies on this (a search in the repo for 'playground' should be enough to know. ) |
@orta where is the vscode-ts-playground code? I searched in microsoft/vscode but didn't see anything that looked definitively like it. |
Hrm, you might not have access then it's in the microsoft/vscode-web repo /cc @mjbvz |
yep, microsoft/vscode-web is a 404 for me |
I would imagine that we'd want to switch that playground prototype into using |
yes, I just don't know where it is yet |
I also don't have access to |
Sorry, I mean the http server for vscode.dev - so that's probably the repo! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, though I believe that we may want to clean up the tsserver
project a little now that there aren't two entrypoints. I had to do a bunch of movement in the module conversion to support the old web bundle, but that all is not needed now and we eliminate the common file and all of the exports and stuff.
@orta I looked for places in the vscode repo with mentions of |
webServer is now moved to vscode-web, since that's the only project that was using it. This allows tsserver to be a node-only executable instead of conditionally being startable in a webworker.
Implementation notes
process
as a proxy for "running on node". It just assumes it's running on node.@jakebailey I would like for you to check those two things when you have a chance.