-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[For testing only]: Redirect node to bundler #51973
Conversation
@typescript-bot run top200 |
@typescript-bot run top100 |
@typescript-bot run top 200 ? |
@typescript-bot run top 100 |
@typescript-bot is this how I find out I’ve been fired? |
@typescript-bot test top100 |
@typescript-bot test top 100 |
@andrewbranch Here are the results of running the top-repos suite comparing Something interesting changed - please have a look. Details
|
@andrewbranch Here are some more interesting changes from running the top-repos suite Details
|
@andrewbranch Here are some more interesting changes from running the top-repos suite Details
|
@typescript-bot test this |
Heya @DanielRosenwasser, I've started to run the extended test suite on this PR at ee87f10. You can monitor the build here. |
Heya @DanielRosenwasser, I've started to run the diff-based user code test suite (tsserver) on this PR at ee87f10. You can monitor the build here. Update: The results are in! |
Heya @DanielRosenwasser, I've started to run the diff-based user code test suite on this PR at ee87f10. You can monitor the build here. Update: The results are in! |
Heya @DanielRosenwasser, I've started to run the abridged perf test suite on this PR at ee87f10. You can monitor the build here. |
Heya @DanielRosenwasser, I've started to run the parallelized Definitely Typed test suite on this PR at ee87f10. You can monitor the build here. |
Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite (tsserver) on this PR at ee87f10. You can monitor the build here. Update: The results are in! |
@typescript-bot perf test this |
Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at ee87f10. You can monitor the build here. Update: The results are in! |
@DanielRosenwasser Here are the results of running the user test suite comparing Everything looks good! |
@DanielRosenwasser Here are the results of running the user test suite comparing Something interesting changed - please have a look. Details
|
Heya @DanielRosenwasser, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here. |
@DanielRosenwasser Here are the results of running the top-repos suite comparing Something interesting changed - please have a look. Detailsbackstage/backstage
|
Re: #51973 (comment)
|
I haven’t looked at Puppeteer yet, but I’m looking at |
That doesn’t sound intentional. I intentionally backed out some changes that would have required this when I realized that it negatively impacts monorepos. |
@DanielRosenwasser Here they are:
CompilerComparison Report - main..51973
System
Hosts
Scenarios
TSServerComparison Report - main..51973
System
Hosts
Scenarios
StartupComparison Report - main..51973
System
Hosts
Scenarios
Developer Information: |
Brought in #51995 |
@typescript-bot test top 100 |
@typescript-bot test top100 |
Heya @andrewbranch, I've started to run the diff-based top-repos suite on this PR at 6ba17c8. You can monitor the build here. Update: The results are in! |
@andrewbranch Here are the results of running the top-repos suite comparing Something interesting changed - please have a look. Details
|
Ok, so the rest of these errors all have a common cause, and they are strictly correct, though I didn’t foresee this problem being so pervasive. Each of these errors is caused by an incorrectly configured npm dependency that would also occur under Essentially, this is just an extension of the problem we knew we’d face with I’m not sure there’s much to do here other than:
|
…ports-respecting modes
@typescript-bot test top100 |
Heya @andrewbranch, I've started to run the diff-based top-repos suite on this PR at 6b1da23. You can monitor the build here. Update: The results are in! |
@andrewbranch Here are the results of running the top-repos suite comparing Something interesting changed - please have a look. Details
|
I have pointed out this problem in #50466 |
No description provided.