Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save jsdoc comments in string, not array #53048

Closed
wants to merge 4 commits into from
Closed

Save jsdoc comments in string, not array #53048

wants to merge 4 commits into from

Conversation

sandersn
Copy link
Member

@sandersn sandersn commented Mar 1, 2023

A cleanup of the first commit in #53007, after I realised that the next good target for improvement is the scanner, and changes there might obviate the ones in #53007

First step toward addressing #52959

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 1, 2023
@sandersn sandersn marked this pull request as ready for review March 1, 2023 18:24
@sandersn sandersn changed the title Save jsdoc comments in string not array 2 Save jsdoc comments in string, not array Mar 1, 2023
@sandersn
Copy link
Member Author

sandersn commented Mar 1, 2023

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 1, 2023 •
edited
Loading

Heya @sandersn, I've started to run the perf test suite on this PR at 4c21bf5. You can monitor the build here.

Update: The results are in!

@jakebailey
Copy link
Member

Since the perf runner is overloaded with code from main, here's the result from my perf runner with --predictable (which I'm playing with):

Details

Loading benchmark and comparing to baseline.
Comparison Report - main..HEAD

Metric main HEAD Delta Best Worst p-value
Angular - node (v16.17.1, x64)
Memory used 292,225k (± 0.00%) 292,830k (± 0.00%) +605k (+ 0.21%) 292,830k 292,830k p=0.001 n=6
Parse Time 3.33s (± 0.12%) 3.34s (± 0.15%) ~ 3.33s 3.34s p=0.112 n=6
Bind Time 1.29s (± 0.32%) 1.29s (± 0.32%) ~ 1.28s 1.29s p=1.000 n=6
Check Time 10.30s (± 0.07%) 10.32s (± 0.12%) +0.02s (+ 0.15%) 10.30s 10.33s p=0.046 n=6
Emit Time 8.66s (± 0.17%) 8.67s (± 0.10%) ~ 8.66s 8.68s p=0.284 n=6
Total Time 23.58s (± 0.07%) 23.61s (± 0.09%) ~ 23.59s 23.65s p=0.051 n=6
Compiler - node (v16.17.1, x64)
Memory used 173,592k (± 0.01%) 173,637k (± 0.01%) +45k (+ 0.03%) 173,632k 173,659k p=0.003 n=6
Parse Time 2.00s (± 0.38%) 1.99s (± 0.41%) ~ 1.99s 2.01s p=0.206 n=6
Bind Time 0.93s (± 0.00%) 0.93s (± 0.56%) ~ 0.92s 0.93s p=0.174 n=6
Check Time 8.97s (± 0.06%) 8.99s (± 0.09%) +0.02s (+ 0.22%) 8.98s 9.00s p=0.004 n=6
Emit Time 3.78s (± 0.40%) 3.80s (± 0.40%) ~ 3.78s 3.82s p=0.117 n=6
Total Time 15.67s (± 0.13%) 15.70s (± 0.12%) +0.03s (+ 0.18%) 15.68s 15.73s p=0.036 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 191,298k (± 0.01%) 191,309k (± 0.01%) ~ 191,255k 191,320k p=0.262 n=6
Parse Time 1.77s (± 0.36%) 1.76s (± 0.23%) -0.01s (- 0.47%) 1.76s 1.77s p=0.033 n=6
Bind Time 0.91s (± 0.00%) 0.91s (± 0.45%) ~ 0.91s 0.92s p=0.405 n=6
Check Time 10.92s (± 0.06%) 10.93s (± 0.07%) ~ 10.92s 10.94s p=0.177 n=6
Emit Time 3.75s (± 0.17%) 3.75s (± 0.11%) ~ 3.75s 3.76s p=0.673 n=6
Total Time 17.35s (± 0.09%) 17.35s (± 0.05%) ~ 17.34s 17.36s p=0.774 n=6
Monaco - node (v16.17.1, x64)
Memory used 343,033k (± 0.00%) 343,106k (± 0.00%) +73k (+ 0.02%) 343,106k 343,106k p=0.001 n=6
Parse Time 2.99s (± 0.28%) 2.96s (± 0.35%) -0.04s (- 1.28%) 2.94s 2.97s p=0.004 n=6
Bind Time 1.48s (± 0.00%) 1.48s (± 0.00%) ~ 1.48s 1.48s p=1.000 n=6
Check Time 8.70s (± 0.05%) 8.71s (± 0.10%) +0.02s (+ 0.19%) 8.70s 8.72s p=0.009 n=6
Emit Time 4.99s (± 0.10%) 4.99s (± 0.11%) -0.01s (- 0.17%) 4.98s 4.99s p=0.038 n=6
Total Time 18.16s (± 0.07%) 18.14s (± 0.11%) -0.03s (- 0.15%) 18.10s 18.16s p=0.023 n=6
TFS - node (v16.17.1, x64)
Memory used 298,797k (± 0.01%) 298,873k (± 0.00%) +76k (+ 0.03%) 298,869k 298,884k p=0.003 n=6
Parse Time 2.56s (± 0.20%) 2.55s (± 0.29%) -0.01s (- 0.46%) 2.54s 2.56s p=0.020 n=6
Bind Time 1.11s (± 0.00%) 1.11s (± 0.37%) ~ 1.11s 1.12s p=0.405 n=6
Check Time 8.51s (± 0.12%) 8.49s (± 0.14%) -0.02s (- 0.24%) 8.47s 8.50s p=0.016 n=6
Emit Time 5.44s (± 0.12%) 5.44s (± 0.18%) ~ 5.43s 5.45s p=0.733 n=6
Total Time 17.62s (± 0.11%) 17.59s (± 0.10%) -0.03s (- 0.20%) 17.57s 17.62s p=0.019 n=6
material-ui - node (v16.17.1, x64)
Memory used 472,141k (± 0.00%) 472,670k (± 0.00%) +529k (+ 0.11%) 472,670k 472,670k p=0.001 n=6
Parse Time 3.47s (± 0.15%) 3.42s (± 0.12%) -0.04s (- 1.30%) 3.42s 3.43s p=0.003 n=6
Bind Time 1.18s (± 0.44%) 1.14s (± 0.00%) 🟩-0.04s (- 3.66%) 1.14s 1.14s p=0.002 n=6
Check Time 20.77s (± 0.04%) 20.75s (± 0.16%) ~ 20.72s 20.80s p=0.250 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 25.42s (± 0.03%) 25.31s (± 0.12%) -0.11s (- 0.43%) 25.28s 25.36s p=0.005 n=6
xstate - node (v16.17.1, x64)
Memory used 526,111k (± 0.00%) 528,020k (± 0.00%) +1,909k (+ 0.36%) 528,020k 528,020k p=0.001 n=6
Parse Time 4.71s (± 0.11%) 4.61s (± 0.11%) -0.10s (- 2.12%) 4.60s 4.61s p=0.004 n=6
Bind Time 1.59s (± 0.00%) 1.59s (± 0.26%) ~ 1.59s 1.60s p=0.405 n=6
Check Time 3.48s (± 0.15%) 3.53s (± 0.21%) +0.05s (+ 1.29%) 3.52s 3.54s p=0.004 n=6
Emit Time 0.09s (± 0.00%) 0.12s (± 0.00%) 🔻+0.03s (+33.33%) 0.12s 0.12s p=0.001 n=6
Total Time 9.87s (± 0.05%) 9.85s (± 0.13%) -0.03s (- 0.25%) 9.83s 9.87s p=0.009 n=6
System
Machine Nameelcheapo
Platformlinux 6.2.1-arch1-1
Architecturex64
Available Memory8 GB
Available Memory7 GB
CPUs6 × Intel(R) Core(TM) i5-8400 CPU @ 2.80GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • Angular - node (v16.17.1, x64)
  • Compiler - node (v16.17.1, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Monaco - node (v16.17.1, x64)
  • TFS - node (v16.17.1, x64)
  • material-ui - node (v16.17.1, x64)
  • xstate - node (v16.17.1, x64)
Benchmark Name Iterations
Current HEAD 6
Baseline main 6

@jakebailey
Copy link
Member

So, seems to be a little better, but worse in memory usage? I guess I'll be curious what the real runner says, for comparison.

@typescript-bot
Copy link
Collaborator

@sandersn
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..53048
Metric main 53048 Delta Best Worst p-value
Angular - node (v18.10.0, x64)
Memory used 359,766k (± 0.01%) 360,859k (± 0.01%) +1,094k (+ 0.30%) 360,783k 360,909k p=0.005 n=6
Parse Time 3.50s (± 0.35%) 3.49s (± 0.96%) ~ 3.44s 3.52s p=1.000 n=6
Bind Time 1.13s (± 0.67%) 1.13s (± 0.87%) ~ 1.12s 1.14s p=0.554 n=6
Check Time 8.61s (± 0.45%) 8.63s (± 0.71%) ~ 8.56s 8.74s p=0.808 n=6
Emit Time 7.44s (± 0.87%) 7.43s (± 0.56%) ~ 7.38s 7.49s p=0.872 n=6
Total Time 20.68s (± 0.41%) 20.68s (± 0.55%) ~ 20.58s 20.89s p=0.936 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used 190,502k (± 1.20%) 191,589k (± 1.55%) ~ 189,638k 195,615k p=0.066 n=6
Parse Time 1.48s (± 0.35%) 1.44s (± 1.16%) -0.04s (- 2.48%) 1.42s 1.47s p=0.006 n=6
Bind Time 0.76s (± 0.68%) 0.77s (± 0.53%) +0.01s (+ 1.09%) 0.77s 0.78s p=0.022 n=6
Check Time 9.28s (± 0.35%) 9.32s (± 0.96%) ~ 9.23s 9.42s p=0.685 n=6
Emit Time 2.73s (± 0.72%) 2.75s (± 1.31%) ~ 2.71s 2.81s p=0.416 n=6
Total Time 14.24s (± 0.33%) 14.27s (± 0.79%) ~ 14.15s 14.44s p=0.810 n=6
Monaco - node (v18.10.0, x64)
Memory used 343,865k (± 0.02%) 343,961k (± 0.01%) +96k (+ 0.03%) 343,869k 343,998k p=0.037 n=6
Parse Time 2.64s (± 0.68%) 2.63s (± 1.11%) ~ 2.59s 2.68s p=0.293 n=6
Bind Time 1.00s (± 0.75%) 1.01s (± 0.40%) ~ 1.00s 1.01s p=0.100 n=6
Check Time 7.02s (± 0.77%) 7.01s (± 0.47%) ~ 6.97s 7.05s p=0.872 n=6
Emit Time 4.24s (± 1.11%) 4.23s (± 0.66%) ~ 4.18s 4.26s p=0.468 n=6
Total Time 14.90s (± 0.63%) 14.88s (± 0.47%) ~ 14.82s 15.00s p=0.748 n=6
TFS - node (v18.10.0, x64)
Memory used 299,889k (± 0.01%) 299,946k (± 0.01%) +57k (+ 0.02%) 299,912k 299,960k p=0.005 n=6
Parse Time 2.04s (± 1.37%) 2.05s (± 0.89%) ~ 2.03s 2.07s p=0.371 n=6
Bind Time 1.14s (± 0.66%) 1.13s (± 0.48%) ~ 1.13s 1.14s p=0.476 n=6
Check Time 6.50s (± 0.48%) 6.49s (± 0.47%) ~ 6.45s 6.54s p=0.332 n=6
Emit Time 3.84s (± 0.78%) 3.87s (± 0.58%) ~ 3.85s 3.90s p=0.096 n=6
Total Time 13.52s (± 0.16%) 13.54s (± 0.37%) ~ 13.49s 13.61s p=0.565 n=6
material-ui - node (v18.10.0, x64)
Memory used 476,409k (± 0.00%) 476,920k (± 0.01%) +511k (+ 0.11%) 476,882k 476,958k p=0.005 n=6
Parse Time 3.13s (± 0.44%) 3.11s (± 0.94%) ~ 3.06s 3.14s p=0.072 n=6
Bind Time 0.91s (± 0.45%) 0.91s (± 0.45%) ~ 0.91s 0.92s p=0.218 n=6
Check Time 17.11s (± 0.77%) 17.14s (± 0.66%) ~ 17.04s 17.33s p=0.574 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 21.15s (± 0.67%) 21.16s (± 0.57%) ~ 21.07s 21.38s p=1.000 n=6
xstate - node (v18.10.0, x64)
Memory used 548,094k (± 0.03%) 550,097k (± 0.02%) +2,003k (+ 0.37%) 549,973k 550,213k p=0.005 n=6
Parse Time 4.06s (± 0.44%) 4.02s (± 0.29%) -0.04s (- 1.03%) 4.00s 4.03s p=0.005 n=6
Bind Time 1.67s (± 0.90%) 1.68s (± 0.90%) ~ 1.67s 1.71s p=0.101 n=6
Check Time 2.76s (± 0.55%) 2.76s (± 0.82%) ~ 2.73s 2.79s p=0.871 n=6
Emit Time 0.08s (± 0.00%) 0.08s (± 0.00%) ~ 0.08s 0.08s p=1.000 n=6
Total Time 8.56s (± 0.14%) 8.54s (± 0.27%) ~ 8.52s 8.58s p=0.104 n=6
Angular - node (v16.17.1, x64)
Memory used 359,066k (± 0.00%) 360,136k (± 0.01%) +1,071k (+ 0.30%) 360,099k 360,158k p=0.005 n=6
Parse Time 3.71s (± 0.31%) 3.72s (± 0.62%) ~ 3.68s 3.75s p=0.222 n=6
Bind Time 1.20s (± 0.46%) 1.20s (± 0.63%) ~ 1.19s 1.21s p=0.476 n=6
Check Time 9.44s (± 0.43%) 9.46s (± 0.48%) ~ 9.40s 9.53s p=0.575 n=6
Emit Time 7.89s (± 0.57%) 7.91s (± 0.96%) ~ 7.81s 8.01s p=0.809 n=6
Total Time 22.24s (± 0.19%) 22.30s (± 0.46%) ~ 22.18s 22.43s p=0.295 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 191,700k (± 0.53%) 191,947k (± 0.67%) +247k (+ 0.13%) 191,388k 194,572k p=0.045 n=6
Parse Time 1.56s (± 0.70%) 1.55s (± 0.88%) ~ 1.53s 1.57s p=0.357 n=6
Bind Time 0.82s (± 0.77%) 0.82s (± 0.92%) ~ 0.81s 0.83s p=0.718 n=6
Check Time 10.06s (± 0.46%) 10.17s (± 0.76%) +0.11s (+ 1.04%) 10.07s 10.28s p=0.019 n=6
Emit Time 3.00s (± 0.91%) 3.02s (± 1.81%) ~ 2.95s 3.10s p=0.628 n=6
Total Time 15.44s (± 0.48%) 15.56s (± 0.58%) ~ 15.46s 15.73s p=0.054 n=6
Monaco - node (v16.17.1, x64)
Memory used 343,124k (± 0.01%) 343,207k (± 0.00%) +83k (+ 0.02%) 343,189k 343,223k p=0.005 n=6
Parse Time 2.78s (± 0.45%) 2.79s (± 0.93%) ~ 2.77s 2.83s p=0.359 n=6
Bind Time 1.08s (± 1.01%) 1.08s (± 1.48%) ~ 1.05s 1.10s p=0.858 n=6
Check Time 7.68s (± 0.59%) 7.71s (± 0.58%) ~ 7.66s 7.79s p=0.377 n=6
Emit Time 4.42s (± 0.44%) 4.44s (± 0.96%) ~ 4.39s 4.51s p=0.571 n=6
Total Time 15.97s (± 0.32%) 16.03s (± 0.52%) ~ 15.93s 16.14s p=0.228 n=6
TFS - node (v16.17.1, x64)
Memory used 299,254k (± 0.01%) 299,299k (± 0.00%) +45k (+ 0.01%) 299,289k 299,316k p=0.005 n=6
Parse Time 2.16s (± 1.22%) 2.17s (± 0.69%) ~ 2.15s 2.19s p=0.549 n=6
Bind Time 1.24s (± 1.31%) 1.25s (± 0.44%) ~ 1.24s 1.25s p=0.663 n=6
Check Time 7.18s (± 0.11%) 7.16s (± 0.33%) ~ 7.13s 7.20s p=0.157 n=6
Emit Time 4.34s (± 1.24%) 4.34s (± 0.96%) ~ 4.30s 4.40s p=0.871 n=6
Total Time 14.92s (± 0.46%) 14.91s (± 0.43%) ~ 14.84s 15.01s p=1.000 n=6
material-ui - node (v16.17.1, x64)
Memory used 475,645k (± 0.01%) 476,205k (± 0.02%) +560k (+ 0.12%) 476,152k 476,372k p=0.005 n=6
Parse Time 3.28s (± 0.19%) 3.27s (± 0.37%) ~ 3.25s 3.28s p=0.059 n=6
Bind Time 0.95s (± 0.57%) 0.96s (± 0.78%) ~ 0.95s 0.97s p=0.476 n=6
Check Time 18.05s (± 0.21%) 18.18s (± 1.08%) ~ 18.04s 18.55s p=0.195 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.29s (± 0.18%) 22.41s (± 0.89%) ~ 22.24s 22.78s p=0.378 n=6
xstate - node (v16.17.1, x64)
Memory used 545,614k (± 0.02%) 547,824k (± 0.03%) +2,210k (+ 0.41%) 547,663k 548,116k p=0.005 n=6
Parse Time 4.26s (± 0.23%) 4.21s (± 0.48%) -0.05s (- 1.25%) 4.19s 4.23s p=0.004 n=6
Bind Time 1.76s (± 0.66%) 1.78s (± 0.75%) ~ 1.76s 1.80s p=0.058 n=6
Check Time 2.98s (± 0.56%) 2.98s (± 0.69%) ~ 2.96s 3.01s p=0.743 n=6
Emit Time 0.09s (± 0.00%) 0.09s (± 0.00%) ~ 0.09s 0.09s p=1.000 n=6
Total Time 9.09s (± 0.20%) 9.07s (± 0.40%) ~ 9.02s 9.11s p=0.227 n=6
Angular - node (v14.15.1, x64)
Memory used 352,833k (± 0.00%) 353,888k (± 0.01%) +1,055k (+ 0.30%) 353,855k 353,909k p=0.005 n=6
Parse Time 3.69s (± 0.56%) 3.71s (± 0.81%) ~ 3.68s 3.76s p=0.168 n=6
Bind Time 1.24s (± 0.33%) 1.24s (± 0.41%) ~ 1.24s 1.25s p=0.595 n=6
Check Time 9.71s (± 0.62%) 9.73s (± 0.48%) ~ 9.69s 9.82s p=0.520 n=6
Emit Time 8.35s (± 0.82%) 8.36s (± 1.08%) ~ 8.25s 8.49s p=1.000 n=6
Total Time 22.99s (± 0.49%) 23.03s (± 0.56%) ~ 22.89s 23.18s p=0.688 n=6
Compiler-Unions - node (v14.15.1, x64)
Memory used 186,532k (± 0.02%) 186,397k (± 0.02%) -135k (- 0.07%) 186,340k 186,425k p=0.005 n=6
Parse Time 1.57s (± 0.57%) 1.56s (± 0.33%) ~ 1.56s 1.57s p=0.190 n=6
Bind Time 0.84s (± 0.61%) 0.84s (± 0.61%) ~ 0.84s 0.85s p=1.000 n=6
Check Time 10.17s (± 0.59%) 10.25s (± 0.80%) ~ 10.09s 10.30s p=0.063 n=6
Emit Time 3.11s (± 0.72%) 3.47s (± 1.42%) +0.35s (+11.40%) 3.42s 3.55s p=0.005 n=6
Total Time 15.70s (± 0.41%) 16.13s (± 0.44%) +0.43s (+ 2.75%) 16.01s 16.21s p=0.005 n=6
Monaco - node (v14.15.1, x64)
Memory used 338,119k (± 0.01%) 338,208k (± 0.01%) +89k (+ 0.03%) 338,168k 338,239k p=0.005 n=6
Parse Time 2.89s (± 0.81%) 2.88s (± 0.47%) ~ 2.86s 2.90s p=0.192 n=6
Bind Time 1.10s (± 0.57%) 1.11s (± 0.37%) +0.01s (+ 0.76%) 1.10s 1.11s p=0.033 n=6
Check Time 8.08s (± 0.47%) 8.10s (± 0.39%) ~ 8.07s 8.14s p=0.871 n=6
Emit Time 4.68s (± 0.69%) 4.71s (± 1.07%) ~ 4.64s 4.77s p=0.199 n=6
Total Time 16.76s (± 0.44%) 16.79s (± 0.50%) ~ 16.68s 16.89s p=0.423 n=6
TFS - node (v14.15.1, x64)
Memory used 294,293k (± 0.00%) 294,326k (± 0.00%) +33k (+ 0.01%) 294,318k 294,332k p=0.005 n=6
Parse Time 2.38s (± 0.49%) 2.38s (± 0.59%) ~ 2.36s 2.40s p=0.934 n=6
Bind Time 1.06s (± 0.49%) 1.06s (± 0.38%) ~ 1.06s 1.07s p=0.595 n=6
Check Time 7.45s (± 0.36%) 7.48s (± 0.56%) ~ 7.43s 7.54s p=0.213 n=6
Emit Time 4.29s (± 0.80%) 4.28s (± 0.53%) ~ 4.25s 4.30s p=0.686 n=6
Total Time 15.18s (± 0.23%) 15.20s (± 0.32%) ~ 15.13s 15.27s p=0.468 n=6
material-ui - node (v14.15.1, x64)
Memory used 471,337k (± 0.01%) 471,865k (± 0.01%) +528k (+ 0.11%) 471,819k 471,909k p=0.005 n=6
Parse Time 3.44s (± 0.67%) 3.46s (± 0.46%) ~ 3.45s 3.49s p=0.072 n=6
Bind Time 1.01s (± 0.83%) 1.00s (± 0.98%) ~ 0.99s 1.02s p=0.396 n=6
Check Time 18.90s (± 0.69%) 19.04s (± 0.51%) ~ 18.91s 19.14s p=0.077 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 23.35s (± 0.58%) 23.51s (± 0.34%) +0.16s (+ 0.69%) 23.39s 23.60s p=0.045 n=6
xstate - node (v14.15.1, x64)
Memory used 534,369k (± 0.00%) 536,381k (± 0.01%) +2,011k (+ 0.38%) 536,338k 536,443k p=0.005 n=6
Parse Time 4.56s (± 0.43%) 4.38s (± 0.27%) 🟩-0.17s (- 3.84%) 4.37s 4.40s p=0.005 n=6
Bind Time 1.66s (± 0.49%) 1.80s (± 0.58%) +0.14s (+ 8.35%) 1.78s 1.81s p=0.004 n=6
Check Time 3.13s (± 0.42%) 3.13s (± 0.80%) ~ 3.10s 3.17s p=0.871 n=6
Emit Time 0.10s (± 0.00%) 0.10s (± 5.76%) ~ 0.09s 0.10s p=0.071 n=6
Total Time 9.44s (± 0.24%) 9.41s (± 0.36%) ~ 9.37s 9.47s p=0.075 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 53048 6
Baseline main 6

TSServer

Comparison Report - main..53048
Metric main 53048 Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,365ms (± 0.79%) 2,354ms (± 1.03%) ~ 2,322ms 2,378ms p=0.575 n=6
Req 2 - geterr 5,324ms (± 0.56%) 5,327ms (± 0.59%) ~ 5,294ms 5,382ms p=0.810 n=6
Req 3 - references 329ms (± 1.26%) 327ms (± 1.69%) ~ 323ms 338ms p=0.571 n=6
Req 4 - navto 284ms (± 1.17%) 286ms (± 0.46%) ~ 284ms 288ms p=0.514 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 79ms (± 1.48%) 78ms (± 3.01%) ~ 73ms 79ms p=0.357 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,508ms (± 0.95%) 2,504ms (± 1.08%) ~ 2,473ms 2,551ms p=0.748 n=6
Req 2 - geterr 3,996ms (± 0.46%) 3,976ms (± 0.85%) ~ 3,924ms 4,030ms p=0.173 n=6
Req 3 - references 345ms (± 0.28%) 344ms (± 0.73%) ~ 340ms 347ms p=0.742 n=6
Req 4 - navto 292ms (± 0.52%) 293ms (± 0.57%) ~ 291ms 296ms p=0.180 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 68ms (± 3.02%) 72ms (± 8.45%) ~ 67ms 83ms p=0.253 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 3,163ms (± 0.36%) 3,139ms (± 0.47%) -25ms (- 0.77%) 3,123ms 3,159ms p=0.031 n=6
Req 2 - geterr 1,626ms (± 0.77%) 1,609ms (± 0.47%) -17ms (- 1.01%) 1,600ms 1,620ms p=0.037 n=6
Req 3 - references 105ms (± 2.92%) 103ms (± 1.33%) ~ 101ms 105ms p=0.075 n=6
Req 4 - navto 359ms (± 0.34%) 357ms (± 0.79%) ~ 353ms 360ms p=0.220 n=6
Req 5 - completionInfo count 3,136 (± 0.00%) 3,136 (± 0.00%) ~ 3,136 3,136 p=1.000 n=6
Req 5 - completionInfo 426ms (± 0.92%) 430ms (± 1.47%) ~ 423ms 437ms p=0.198 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,486ms (± 2.00%) 2,474ms (± 1.64%) ~ 2,450ms 2,555ms p=0.688 n=6
Req 2 - geterr 5,699ms (± 0.82%) 5,728ms (± 0.50%) ~ 5,684ms 5,764ms p=0.378 n=6
Req 3 - references 340ms (± 0.96%) 341ms (± 0.79%) ~ 338ms 346ms p=0.335 n=6
Req 4 - navto 279ms (± 1.04%) 280ms (± 0.95%) ~ 276ms 283ms p=0.466 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 87ms (± 3.17%) 86ms (± 2.49%) ~ 84ms 90ms p=0.391 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,672ms (± 0.72%) 2,673ms (± 1.00%) ~ 2,633ms 2,701ms p=0.873 n=6
Req 2 - geterr 4,359ms (± 0.46%) 4,366ms (± 0.41%) ~ 4,335ms 4,386ms p=0.471 n=6
Req 3 - references 357ms (± 0.88%) 358ms (± 1.16%) ~ 354ms 365ms p=0.686 n=6
Req 4 - navto 287ms (± 1.09%) 289ms (± 1.12%) ~ 283ms 293ms p=0.288 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 75ms (± 3.21%) 76ms (± 3.89%) ~ 73ms 79ms p=1.000 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 3,319ms (± 0.26%) 3,298ms (± 0.54%) -22ms (- 0.65%) 3,284ms 3,331ms p=0.045 n=6
Req 2 - geterr 1,758ms (± 0.38%) 1,857ms (± 4.49%) +99ms (+ 5.65%) 1,752ms 1,938ms p=0.045 n=6
Req 3 - references 111ms (± 0.93%) 111ms (± 1.59%) ~ 108ms 113ms p=0.437 n=6
Req 4 - navto 343ms (± 1.03%) 346ms (± 0.91%) ~ 342ms 351ms p=0.172 n=6
Req 5 - completionInfo count 3,136 (± 0.00%) 3,136 (± 0.00%) ~ 3,136 3,136 p=1.000 n=6
Req 5 - completionInfo 435ms (± 1.16%) 436ms (± 0.86%) ~ 433ms 441ms p=0.807 n=6
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,565ms (± 0.52%) 2,565ms (± 0.34%) ~ 2,554ms 2,579ms p=0.810 n=6
Req 2 - geterr 6,037ms (± 0.16%) 6,056ms (± 0.33%) ~ 6,036ms 6,091ms p=0.065 n=6
Req 3 - references 359ms (± 1.18%) 357ms (± 0.77%) ~ 353ms 361ms p=0.570 n=6
Req 4 - navto 277ms (± 1.48%) 276ms (± 1.22%) ~ 274ms 283ms p=0.678 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 97ms (± 8.43%) 100ms (± 4.61%) ~ 91ms 103ms p=0.217 n=6
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,805ms (± 0.77%) 2,818ms (± 0.76%) ~ 2,800ms 2,858ms p=0.470 n=6
Req 2 - geterr 4,415ms (± 0.37%) 4,500ms (± 2.62%) ~ 4,412ms 4,661ms p=0.092 n=6
Req 3 - references 368ms (± 0.15%) 378ms (± 5.04%) ~ 366ms 416ms p=0.101 n=6
Req 4 - navto 295ms (± 0.45%) 293ms (± 1.45%) ~ 286ms 297ms p=0.625 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 103ms (± 0.53%) 90ms (± 9.28%) 🟩-13ms (-12.68%) 83ms 102ms p=0.008 n=6
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,630ms (± 0.73%) 3,616ms (± 0.70%) ~ 3,569ms 3,645ms p=0.470 n=6
Req 2 - geterr 1,834ms (± 1.26%) 1,841ms (± 0.99%) ~ 1,817ms 1,871ms p=0.873 n=6
Req 3 - references 126ms (± 1.79%) 132ms (± 2.23%) +6ms (+ 4.77%) 127ms 136ms p=0.008 n=6
Req 4 - navto 373ms (± 0.31%) 375ms (± 0.54%) ~ 372ms 378ms p=0.059 n=6
Req 5 - completionInfo count 3,136 (± 0.00%) 3,136 (± 0.00%) ~ 3,136 3,136 p=1.000 n=6
Req 5 - completionInfo 446ms (± 1.18%) 462ms (± 1.97%) +16ms (+ 3.51%) 449ms 476ms p=0.013 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 53048 6
Baseline main 6

Startup

Comparison Report - main..53048
Metric main 53048 Delta Best Worst p-value
tsc-startup - node (v16.17.1, x64)
Execution time 142.32ms (± 0.19%) 142.82ms (± 0.24%) +0.50ms (+ 0.35%) 142.07ms 148.25ms p=0.000 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time 227.17ms (± 0.20%) 228.47ms (± 0.25%) +1.30ms (+ 0.57%) 226.94ms 233.81ms p=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 230.05ms (± 0.33%) 229.76ms (± 0.20%) ~ 228.60ms 235.25ms p=0.869 n=600
typescript-startup - node (v16.17.1, x64)
Execution time 210.45ms (± 0.27%) 210.64ms (± 0.21%) +0.18ms (+ 0.09%) 209.43ms 214.66ms p=0.000 n=600
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 53048 6
Baseline main 6

Developer Information:

Download Benchmark

@sandersn
Copy link
Member Author

sandersn commented Mar 2, 2023

wellll, it mostly looks like it's shuffling the GC around, because total time hardly changes. Since memory also increases a little, I guess this one is a dead end, and I should definitely start profiling with --predictable. Too bad, because the code is clearer this way.

@sandersn sandersn closed this Mar 2, 2023
@sandersn sandersn deleted the save-jsdoc-comments-in-string-not-array-2 branch March 2, 2023 16:20
@sandersn sandersn mentioned this pull request Mar 7, 2023
Closed
@sandersn sandersn mentioned this pull request May 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

@jakebailey jakebailey Awaiting requested review from jakebailey

Assignees

@sandersn sandersn

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sandersn @typescript-bot @jakebailey