-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigation: using a mapped form of Omit in rest destructuring #53134
Conversation
Sorry about |
@typescript-bot test this |
Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at 0be6a13. You can monitor the build here. |
Heya @RyanCavanaugh, I've started to run the diff-based user code test suite on this PR at 0be6a13. You can monitor the build here. Update: The results are in! |
Heya @RyanCavanaugh, I've started to run the diff-based user code test suite (tsserver) on this PR at 0be6a13. You can monitor the build here. Update: The results are in! |
Heya @RyanCavanaugh, I've started to run the diff-based top-repos suite on this PR at 0be6a13. You can monitor the build here. Update: The results are in! |
Heya @RyanCavanaugh, I've started to run the perf test suite on this PR at 0be6a13. You can monitor the build here. Update: The results are in! |
Heya @RyanCavanaugh, I've started to run the parallelized Definitely Typed test suite on this PR at 0be6a13. You can monitor the build here. Update: The results are in! |
@RyanCavanaugh Here are the results of running the user test suite comparing Something interesting changed - please have a look. Detailsaxios-src
|
@RyanCavanaugh Here are the results of running the user test suite comparing Everything looks good! |
@RyanCavanaugh Here are the results of running the top-repos suite comparing Everything looks good! |
Hey @RyanCavanaugh, it looks like the DT test run failed. Please check the log for more details. |
@RyanCavanaugh Here are the results of running the top-repos suite comparing Something interesting changed - please have a look. Detailsakveo/ngx-admin
|
@RyanCavanaugh Here are some more interesting changes from running the top-repos suite Detailsgrafana/grafana
|
@RyanCavanaugh Here are some more interesting changes from running the top-repos suite Detailsneoclide/coc.nvim
|
@RyanCavanaugh Here are some more interesting changes from running the top-repos suite Detailsreact-bootstrap/react-bootstrap
|
@RyanCavanaugh Here are some more interesting changes from running the top-repos suite Detailsvuetifyjs/vuetify
|
@RyanCavanaugh Here they are:
CompilerComparison Report - main..53134
System
Hosts
Scenarios
TSServerComparison Report - main..53134
System
Hosts
Scenarios
StartupComparison Report - main..53134
System
Hosts
Scenarios
Developer Information: |
@typescript-bot pack this |
Heya @RyanCavanaugh, I've started to run the tarball bundle task on this PR at 0be6a13. You can monitor the build here. |
Hey @RyanCavanaugh, I've packed this into an installable tgz. You can install it for testing by referencing it in your
and then running There is also a playground for this build and an npm module you can use via |
Another iteration of #53110, #42524. We can't modify the global
Omit
type without breaking the world, but we can certainly introduce a new one 😶. This will cause declaration emit to start producingMappedOmit
from rest destructurings and improves completeness in cases like this: