-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break Pick and Omit #53188
Break Pick and Omit #53188
Conversation
@typescript-bot test this buckle up! |
Heya @RyanCavanaugh, I've started to run the diff-based top-repos suite (tsserver) on this PR at 25014ed. You can monitor the build here. Update: The results are in! |
Heya @RyanCavanaugh, I've started to run the diff-based user code test suite (tsserver) on this PR at 25014ed. You can monitor the build here. Update: The results are in! |
Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at 25014ed. You can monitor the build here. |
Heya @RyanCavanaugh, I've started to run the parallelized Definitely Typed test suite on this PR at 25014ed. You can monitor the build here. Update: The results are in! |
Heya @RyanCavanaugh, I've started to run the perf test suite on this PR at 25014ed. You can monitor the build here. Update: The results are in! |
Heya @RyanCavanaugh, I've started to run the diff-based user code test suite on this PR at 25014ed. You can monitor the build here. Update: The results are in! |
@RyanCavanaugh Here are the results of running the user test suite comparing Something interesting changed - please have a look. Details
|
@RyanCavanaugh Here are the results of running the user test suite comparing Everything looks good! |
Heya @RyanCavanaugh, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here. |
Hey @RyanCavanaugh, the results of running the DT tests are ready. |
@RyanCavanaugh Here are the results of running the top-repos suite comparing Something interesting changed - please have a look. Details
|
@RyanCavanaugh Here are some more interesting changes from running the top-repos suite Details
|
@RyanCavanaugh Here are some more interesting changes from running the top-repos suite Details
|
@RyanCavanaugh Here are the results of running the top-repos suite comparing Everything looks good! |
@RyanCavanaugh Here they are:
CompilerComparison Report - main..53188
System
Hosts
Scenarios
TSServerComparison Report - main..53188
System
Hosts
Scenarios
StartupComparison Report - main..53188
System
Hosts
Scenarios
Developer Information: |
@@ -1582,7 +1582,7 @@ type Extract<T, U> = T extends U ? T : never; | |||
/** | |||
* Construct a type with the properties of T except for those in type K. | |||
*/ | |||
type Omit<T, K extends keyof any> = Pick<T, Exclude<keyof T, K>>; | |||
type Omit<T, K extends keyof any> = { [P in keyof T as Exclude<P, K>]: T[P]; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably also be multi‑line:
type Omit<T, K extends keyof any> = { [P in keyof T as Exclude<P, K>]: T[P]; } | |
type Omit<T, K extends keyof any> = { | |
[P in keyof T as Exclude<P, K>]: T[P]; | |
}; |
Per discussion in #53169