Ignore allowImportingTsExtensions in transpileModule to suppress option validation error with noEmit
#53599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion validation error with `noEmit`
typescript-bot
added
the
For Uncommitted Bug
sheetalkamat
approved these changes
Mar 31, 2023
|
@typescript-bot cherry-pick to release-5.0 |
|
Heya @andrewbranch, I've started to run the task to cherry-pick this into |
|
Hey @andrewbranch, I've opened #53600 for you. |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Mar 31, 2023
Component commits: 2823dd0 Ignore `allowImportingTsExtensions` in transpileModule to suppress option validation error with `noEmit`
andrewbranch
deleted the
bug/allow-importing-ts-extensions-transpile-module
branch
DanielRosenwasser
pushed a commit
that referenced
this pull request
Apr 5, 2023
…e-5.0 (#53600) Co-authored-by: Andrew Branch <[email protected]>
Yangqing
pushed a commit
to leptonai/leptonai
that referenced
this pull request
Sep 8, 2023
…with `noEmit` (#213) part of #193, ref microsoft/TypeScript#53599
drivron
pushed a commit
to scenari/typescript
that referenced
this pull request
Sep 14, 2023
…to release-5.0 (microsoft#53600) Co-authored-by: Andrew Branch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ~ TypeStrong/ts-loader#1602
Fixes ~ TypeStrong/ts-node#1981
ts.transpileModuleerases any value ofnoEmitfrom the incoming compiler options, but still creates a program that does option validation. One validation is thatallowImportingTsExtensionsrequiresnoEmitto be set, so including this option intranspileModulecalls was always an error. The fix is to eraseallowImportingTsExtensionstoo—since its only purpose is to silence an error in checker code that doesn‘t run in transpilation, it’s not necessary to include in the first place. It can be completely ignored in transpilation.