-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(53656): Add support for the updated import attributes proposal #54242
Conversation
Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page. Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up. |
@a-tarasyuk we’d like to get this in for 5.3 beta by Friday. I think the only outstanding thing is the factory API (left a comment on the open thread). Let us know if you’d like to finish it up on such short notice; otherwise one of us can push the last commit or two by Friday. Thanks so much for your work on this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we mark the assertion-specific overloads and functions in the node factory as deprecated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @a-tarasyuk! 🌟
@typescript-bot pack this |
Heya @andrewbranch, I've started to run the tarball bundle task on this PR at e0afc4a. You can monitor the build here. |
Hey @andrewbranch, I've packed this into an installable tgz. You can install it for testing by referencing it in your
and then running There is also a playground for this build and an npm module you can use via |
Looks like a baseline needs to be updated for |
Fixes #53656