Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add inline variable refactor #54281

Merged
merged 35 commits into from
Jun 13, 2023
Merged

Add inline variable refactor #54281

merged 35 commits into from
Jun 13, 2023

Commits on Jun 12, 2023

  1. Add inline variable refactor

    Maria Solano committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    308e643 View commit details
    Browse the repository at this point in the history

  2. Basic tests

    Maria Solano committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    307779e View commit details
    Browse the repository at this point in the history

  3. Offer refactor in reference site

    Maria Solano committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    007a0e1 View commit details
    Browse the repository at this point in the history

  4. Do not offer refactor if there is a write

    Maria Solano committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    c39c34c View commit details
    Browse the repository at this point in the history

  5. Add parenthesize logic

    Maria Solano committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    e477282 View commit details
    Browse the repository at this point in the history

  6. More tests

    Maria Solano committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    32234c0 View commit details
    Browse the repository at this point in the history

  7. Update baselines

    Maria Solano committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    7245421 View commit details
    Browse the repository at this point in the history

  8. Another test

    Maria Solano committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    6d83ed0 View commit details
    Browse the repository at this point in the history

  9. Define the refactor kind

    Maria Solano committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    5579a48 View commit details
    Browse the repository at this point in the history

  10. Limit FAR to one file

    Maria Solano committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    3ad106d View commit details
    Browse the repository at this point in the history

  11. Handle some more invalid cases

    Maria Solano committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    c0e302a View commit details
    Browse the repository at this point in the history

  12. Use eachSymbolReferenceInFile

    Maria Solano committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    095d3b4 View commit details
    Browse the repository at this point in the history

  13. Another error msg

    Maria Solano committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    ce734ff View commit details
    Browse the repository at this point in the history

  14. Exported variable test

    Maria Solano committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    c679717 View commit details
    Browse the repository at this point in the history

  15. Update src/compiler/diagnosticMessages.json 

    Co-authored-by: Andrew Branch <[email protected]>
    @MariaSolOs @andrewbranch
    2 people authored and Maria Solano committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    5e0dfe6 View commit details
    Browse the repository at this point in the history

  16. Update messages

    Maria Solano committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    225b759 View commit details
    Browse the repository at this point in the history

  17. Handle case where declaration has export

    Maria Solano committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    2fb8b04 View commit details
    Browse the repository at this point in the history

  18. More tests

    Maria Solano committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    1e6d8cd View commit details
    Browse the repository at this point in the history

  19. Add inline callback case

    Maria Solano committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    b2d9018 View commit details
    Browse the repository at this point in the history

  20. Handle Daniel's recursive case

    Maria Solano committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    9bc6c05 View commit details
    Browse the repository at this point in the history

  21. Improve comments

    @MariaSolOs
    MariaSolOs authored and Maria Solano committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    a259b3a View commit details
    Browse the repository at this point in the history

  22. Use deep clones for replacements

    @MariaSolOs
    MariaSolOs authored and Maria Solano committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    b308e99 View commit details
    Browse the repository at this point in the history

  23. Use textRangeContainsPositionInclusive

    @MariaSolOs
    MariaSolOs authored and Maria Solano committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    76bd29a View commit details
    Browse the repository at this point in the history

  24. deep clone for each replacement

    @MariaSolOs
    MariaSolOs authored and Maria Solano committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    4080541 View commit details
    Browse the repository at this point in the history

  25. Update src/services/refactors/inlineVariable.ts 

    Co-authored-by: Daniel Rosenwasser <[email protected]>
    @MariaSolOs @DanielRosenwasser
    2 people authored and Maria Solano committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    9f39bfb View commit details
    Browse the repository at this point in the history

  26. Clone the replacement node

    Maria Solano committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    4fa54f7 View commit details
    Browse the repository at this point in the history

  27. Restrict availability to identifier only

    Maria Solano committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    4e608ef View commit details
    Browse the repository at this point in the history

  28. Improve exported variable checks

    Maria Solano committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    ca090ef View commit details
    Browse the repository at this point in the history

  29. Handle functions

    Maria Solano committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    4c8335f View commit details
    Browse the repository at this point in the history

  30. Look at the merged symbol

    Maria Solano committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    206a2df View commit details
    Browse the repository at this point in the history

  31. More comments

    Maria Solano committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    49b38db View commit details
    Browse the repository at this point in the history

  32. Improve error message

    Maria Solano committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    67a5880 View commit details
    Browse the repository at this point in the history

  33. control flow nits

    Maria Solano committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    7c7202a View commit details
    Browse the repository at this point in the history

  34. Use getTouchingPropertyName

    Maria Solano committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    4539610 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. Add availability test

    @MariaSolOs
    MariaSolOs committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    b040942 View commit details
    Browse the repository at this point in the history