Allow variance annotations on generic references #56418

JoshuaKGoldberg · 2023-11-15T22:27:40Z

Adds ObjectFlags.Reference to the allowed object flags, to encompass generic interfaces. Also adds tests to ensure that multi-layered type references to object or primitive (number) shapes still error only when they should.

jakebailey · 2023-11-15T23:57:02Z

@typescript-bot test top200
@typescript-bot user test this
@typescript-bot run dt

@typescript-bot perf test this
@typescript-bot pack this

typescript-bot · 2023-11-15T23:57:05Z

Heya @jakebailey, I've started to run the regular perf test suite on this PR at 79e0c3a. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-11-15T23:57:05Z

Heya @jakebailey, I've started to run the tarball bundle task on this PR at 79e0c3a. You can monitor the build here.

typescript-bot · 2023-11-15T23:57:05Z

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 79e0c3a. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-11-15T23:57:05Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 79e0c3a. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-11-15T23:57:05Z

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 79e0c3a. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-11-15T23:59:00Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/158624/artifacts?artifactName=tgz&fileId=1332F4A856A6ED1D3815FCF1733754B86EC8BA9B54E73DADAEEB2B182714BA4502&fileName=/typescript-5.4.0-insiders.20231115.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

typescript-bot · 2023-11-16T00:17:07Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/56418/merge:

There were infrastructure failures potentially unrelated to your change:

2 instances of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

packages/browsers/test/src/tsconfig.json

[MISSING] error TS2307: Cannot find module '@pptr/testserver' or its corresponding type declarations.
- packages/browsers/test/src/utils.ts#L23 in packages/browsers/test/src/tsconfig.json

typescript-bot · 2023-11-16T00:25:02Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,199k (± 0.01%)}	_{295,160k (± 0.01%)}	_~	_295,102k	_295,179k	_{p=0.128 n=6}
_{Parse Time}	_{2.64s (± 0.20%)}	_{2.63s (± 0.44%)}	_{-0.01s (- 0.44%)}	_2.61s	_2.64s	_{p=0.039 n=6}
_{Bind Time}	_{0.82s (± 0.00%)}	_{0.82s (± 0.63%)}	_~	_0.82s	_0.83s	_{p=0.174 n=6}
_{Check Time}	_{8.04s (± 0.37%)}	_{8.05s (± 0.31%)}	_~	_8.02s	_8.09s	_{p=0.809 n=6}
_{Emit Time}	_{7.09s (± 0.30%)}	_{7.08s (± 0.26%)}	_~	_7.05s	_7.10s	_{p=0.293 n=6}
_{Total Time}	_{18.59s (± 0.15%)}	_{18.58s (± 0.21%)}	_~	_18.55s	_18.65s	_{p=0.418 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{193,620k (± 1.63%)}	_{191,664k (± 1.23%)}	_~	_190,663k	_196,486k	_{p=0.149 n=6}
_{Parse Time}	_{1.36s (± 1.14%)}	_{1.36s (± 0.93%)}	_~	_1.35s	_1.38s	_{p=0.928 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.57%)}	_~	_0.72s	_0.73s	_{p=0.405 n=6}
_{Check Time}	_{9.18s (± 0.11%)}	_{9.15s (± 0.34%)}	_{-0.04s (- 0.42%)}	_9.11s	_9.19s	_{p=0.043 n=6}
_{Emit Time}	_{2.64s (± 0.72%)}	_{2.63s (± 0.59%)}	_~	_2.62s	_2.66s	_{p=0.448 n=6}
_{Total Time}	_{13.90s (± 0.24%)}	_{13.86s (± 0.33%)}	_~	_13.81s	_13.92s	_{p=0.127 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,355k (± 0.00%)}	_{347,343k (± 0.01%)}	_~	_347,298k	_347,386k	_{p=0.575 n=6}
_{Parse Time}	_{2.46s (± 0.36%)}	_{2.45s (± 0.49%)}	_~	_2.43s	_2.46s	_{p=0.437 n=6}
_{Bind Time}	_{0.93s (± 0.44%)}	_{0.93s (± 0.56%)}	_~	_0.92s	_0.93s	_{p=0.595 n=6}
_{Check Time}	_{6.92s (± 0.50%)}	_{6.91s (± 0.52%)}	_~	_6.86s	_6.96s	_{p=0.629 n=6}
_{Emit Time}	_{4.05s (± 0.58%)}	_{4.05s (± 0.35%)}	_~	_4.03s	_4.07s	_{p=1.000 n=6}
_{Total Time}	_{14.36s (± 0.32%)}	_{14.34s (± 0.17%)}	_~	_14.31s	_14.37s	_{p=0.333 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,622k (± 0.00%)}	_{302,628k (± 0.00%)}	_~	_302,606k	_302,641k	_{p=0.423 n=6}
_{Parse Time}	_{2.00s (± 0.60%)}	_{2.00s (± 0.97%)}	_~	_1.98s	_2.03s	_{p=0.806 n=6}
_{Bind Time}	_{1.00s (± 0.98%)}	_{1.00s (± 0.98%)}	_~	_0.99s	_1.02s	_{p=1.000 n=6}
_{Check Time}	_{6.25s (± 0.48%)}	_{6.26s (± 0.33%)}	_~	_6.24s	_6.29s	_{p=0.516 n=6}
_{Emit Time}	_{3.56s (± 0.25%)}	_{3.57s (± 0.62%)}	_~	_3.54s	_3.60s	_{p=0.368 n=6}
_{Total Time}	_{12.82s (± 0.32%)}	_{12.84s (± 0.28%)}	_~	_12.80s	_12.89s	_{p=0.377 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{470,564k (± 0.00%)}	_{470,544k (± 0.01%)}	_~	_470,509k	_470,585k	_{p=0.109 n=6}
_{Parse Time}	_{2.57s (± 0.45%)}	_{2.57s (± 0.74%)}	_~	_2.55s	_2.60s	_{p=1.000 n=6}
_{Bind Time}	_{0.99s (± 0.64%)}	_{0.99s (± 0.64%)}	_~	_0.98s	_1.00s	_{p=1.000 n=6}
_{Check Time}	_{16.73s (± 0.33%)}	_{16.66s (± 0.36%)}	_~	_16.60s	_16.77s	_{p=0.062 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.29s (± 0.33%)}	_{20.22s (± 0.26%)}	_{-0.07s (- 0.36%)}	_20.18s	_20.32s	_{p=0.044 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,822k (± 0.01%)}	_{512,814k (± 0.01%)}	_~	_512,742k	_512,908k	_{p=0.936 n=6}
_{Parse Time}	_{3.28s (± 0.19%)}	_{3.27s (± 0.17%)}	_{-0.02s (- 0.46%)}	_3.26s	_3.27s	_{p=0.007 n=6}
_{Bind Time}	_{1.54s (± 0.58%)}	_{1.54s (± 0.49%)}	_~	_1.53s	_1.55s	_{p=0.798 n=6}
_{Check Time}	_{2.86s (± 0.76%)}	_{2.87s (± 0.52%)}	_~	_2.85s	_2.89s	_{p=0.373 n=6}
_{Emit Time}	_{0.08s (± 4.99%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=0.405 n=6}
_{Total Time}	_{7.76s (± 0.26%)}	_{7.75s (± 0.11%)}	_~	_7.74s	_7.76s	_{p=0.607 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,375ms (± 0.80%)}	_{2,359ms (± 0.44%)}	_~	_2,346ms	_2,374ms	_{p=0.092 n=6}
_{Req 2 - geterr}	_{5,341ms (± 1.05%)}	_{5,406ms (± 1.39%)}	_{+65ms (+ 1.22%)}	_5,321ms	_5,483ms	_{p=0.031 n=6}
_{Req 3 - references}	_{325ms (± 0.75%)}	_{327ms (± 1.68%)}	_~	_323ms	_337ms	_{p=0.627 n=6}
_{Req 4 - navto}	_{279ms (± 0.73%)}	_{276ms (± 1.19%)}	_~	_273ms	_279ms	_{p=0.085 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{81ms (± 6.09%)}	_{84ms (± 7.22%)}	_~	_75ms	_90ms	_{p=0.367 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,492ms (± 0.94%)}	_{2,484ms (± 0.78%)}	_~	_2,454ms	_2,513ms	_{p=0.336 n=6}
_{Req 2 - geterr}	_{4,081ms (± 1.88%)}	_{4,080ms (± 1.83%)}	_~	_4,015ms	_4,178ms	_{p=1.000 n=6}
_{Req 3 - references}	_{340ms (± 1.53%)}	_{340ms (± 1.64%)}	_~	_332ms	_344ms	_{p=0.511 n=6}
_{Req 4 - navto}	_{284ms (± 0.53%)}	_{283ms (± 0.36%)}	_~	_282ms	_285ms	_{p=0.741 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{86ms (± 6.89%)}	_{86ms (± 6.89%)}	_~	_78ms	_90ms	_{p=1.000 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,593ms (± 0.28%)}	_{2,598ms (± 0.36%)}	_~	_2,593ms	_2,617ms	_{p=0.688 n=6}
_{Req 2 - geterr}	_{1,691ms (± 1.91%)}	_{1,716ms (± 2.40%)}	_~	_1,668ms	_1,769ms	_{p=0.298 n=6}
_{Req 3 - references}	_{115ms (± 8.88%)}	_{114ms (± 8.87%)}	_~	_101ms	_123ms	_{p=0.466 n=6}
_{Req 4 - navto}	_{368ms (± 0.42%)}	_{368ms (± 0.37%)}	_~	_365ms	_369ms	_{p=0.432 n=6}
_{Req 5 - completionInfo count}	_{2,073 (± 0.00%)}	_{2,073 (± 0.00%)}	_~	_2,073	_2,073	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{307ms (± 2.35%)}	_{308ms (± 1.73%)}	_~	_301ms	_316ms	_{p=0.810 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{152.68ms (± 0.18%)}	_{152.66ms (± 0.17%)}	_~	_151.64ms	_155.25ms	_{p=0.718 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.13ms (± 0.16%)}	_{228.02ms (± 0.17%)}	_{-0.12ms (- 0.05%)}	_226.73ms	_235.05ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.55ms (± 0.18%)}	_{229.53ms (± 0.17%)}	_~	_228.02ms	_233.30ms	_{p=0.861 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.32ms (± 0.19%)}	_{229.47ms (± 0.16%)}	_{+0.15ms (+ 0.07%)}	_227.89ms	_232.26ms	_{p=0.000 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2023-11-16T00:43:23Z

Hey @jakebailey, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

typescript-bot · 2023-11-16T01:55:39Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/56418/merge:

Everything looks good!

bgenia · 2023-11-16T09:31:46Z

Why does assignability change here if I replace interface with a type alias?

namespace Interface {

    interface InvariantArray<in out T> extends Array<T> { }

    declare let arr: InvariantArray<unknown>
    declare let brr: InvariantArray<number>

    arr = brr // Variance annotations forbid this
    brr = arr

}

namespace TypeAlias {

    type InvariantArray<in out T> = Array<T>

    declare let arr: InvariantArray<unknown>
    declare let brr: InvariantArray<number>

    arr = brr // For some reason this still works?
    brr = arr

}

Playground

fatcerberus · 2023-11-19T20:01:07Z

@bgenia Array is special-cased in the compiler to force covariance. The first version works because you're using a newly minted subtype, but that will also likely stop working too once #55880 gets merged.

…6418)" This reverts commit 41259d5.

…59793)

Allow variance annotations on generic references

79e0c3a

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Nov 15, 2023

JoshuaKGoldberg marked this pull request as ready for review November 15, 2023 23:21

sandersn requested review from weswigham and gabritto November 29, 2023 17:54

sandersn assigned gabritto Nov 29, 2023

gabritto approved these changes Dec 11, 2023

View reviewed changes

gabritto merged commit 41259d5 into microsoft:main Dec 11, 2023
19 checks passed

c0sta pushed a commit to c0sta/TypeScript that referenced this pull request Dec 20, 2023

Allow variance annotations on generic references (microsoft#56418)

fdf870f

JoshuaKGoldberg deleted the variance-allow-reference branch March 2, 2024 14:15

Andarist mentioned this pull request Aug 8, 2024

Variance annotations are not allowed in type aliases for intersections #59561

Open

bgenia mentioned this pull request Aug 29, 2024

Variance annotations in type aliases for interfaces do not affect assignability #59790

Closed

Andarist added a commit to Andarist/TypeScript that referenced this pull request Aug 29, 2024

Revert "Allow variance annotations on generic references (microsoft#5…

c11bc38

…6418)" This reverts commit 41259d5.

gabritto pushed a commit that referenced this pull request Sep 3, 2024

Revert "Allow variance annotations on generic references (#56418)" (#…

29d92ed

…59793)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow variance annotations on generic references #56418

Allow variance annotations on generic references #56418

JoshuaKGoldberg commented Nov 15, 2023

jakebailey commented Nov 15, 2023

typescript-bot commented Nov 15, 2023 •

edited

Loading

typescript-bot commented Nov 15, 2023 •

edited

Loading

typescript-bot commented Nov 15, 2023 •

edited

Loading

typescript-bot commented Nov 15, 2023 •

edited

Loading

typescript-bot commented Nov 15, 2023 •

edited

Loading

typescript-bot commented Nov 15, 2023 •

edited

Loading

typescript-bot commented Nov 16, 2023

puppeteer

packages/browsers/test/src/tsconfig.json

typescript-bot commented Nov 16, 2023

Compiler

tsserver

Startup

typescript-bot commented Nov 16, 2023

typescript-bot commented Nov 16, 2023

bgenia commented Nov 16, 2023

fatcerberus commented Nov 19, 2023

Allow variance annotations on generic references #56418

Allow variance annotations on generic references #56418

Conversation

JoshuaKGoldberg commented Nov 15, 2023

jakebailey commented Nov 15, 2023

typescript-bot commented Nov 15, 2023 • edited Loading

typescript-bot commented Nov 15, 2023 • edited Loading

typescript-bot commented Nov 15, 2023 • edited Loading

typescript-bot commented Nov 15, 2023 • edited Loading

typescript-bot commented Nov 15, 2023 • edited Loading

typescript-bot commented Nov 15, 2023 • edited Loading

typescript-bot commented Nov 16, 2023

puppeteer

packages/browsers/test/src/tsconfig.json

typescript-bot commented Nov 16, 2023

Compiler

tsserver

Startup

typescript-bot commented Nov 16, 2023

typescript-bot commented Nov 16, 2023

bgenia commented Nov 16, 2023

fatcerberus commented Nov 19, 2023

typescript-bot commented Nov 15, 2023 •

edited

Loading

typescript-bot commented Nov 15, 2023 •

edited

Loading

typescript-bot commented Nov 15, 2023 •

edited

Loading

typescript-bot commented Nov 15, 2023 •

edited

Loading

typescript-bot commented Nov 15, 2023 •

edited

Loading

typescript-bot commented Nov 15, 2023 •

edited

Loading