Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stage 3 Decorators normative changes #56955

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Stage 3 Decorators normative changes #56955

merged 3 commits into from
Jan 5, 2024

Conversation

rbuckton
Copy link
Member

@rbuckton rbuckton commented Jan 4, 2024

This changes our Stage 3 Decorators down-level emit to align with recent normative changes to the proposal.

Unfortunately, this will further complicate #55688, which pertains to the emit size for decorators, as this will increase overall emit size since we have to track "extra" initializers on a per-element basis.

Related pzuraq/ecma262#12
Related tc39/proposal-decorators#513
Fixes #56606

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jan 4, 2024
@fatcerberus
Copy link

More normative changes in Stage 3? They really can’t nail this one down, can they?

@rbuckton
Copy link
Member Author

rbuckton commented Jan 4, 2024

More normative changes in Stage 3? They really can’t nail this one down, can they?

This happens with any large proposal. Runtimes generally don't start actual implementations until Stage 3, and once they do there is often feedback that requires normative changes based on implementation experience. The point of Stage 3 is to catch these issues when the rubber hits the road. So far, the changes to Decorators in Stage 3 have been relatively minor compared to other proposals of this magnitude and consist mostly of timing-related changes so that the feature is consistent and meets user expectations. Decorators is actually fairly stable in comparison, and the fact we have only had such minor changes is a testament to the time, energy, and attention to detail of everyone involved in the proposal.

@fatcerberus
Copy link

I guess it seems worse because IIRC decorators were stage 3 originally, then rolled back to stage 2 for a bit, and now are stage 3 again, so the normative changes since then stand out more.

Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on my naive understanding, LGTM 😄

(Needs a dprint fmt).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Normative changes to decorator "extra initializer" evaluation order
4 participants