-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow generateTrace
in tsconfig and compiler API
#59636
Merged
sheetalkamat
merged 7 commits into
microsoft:main
from
dimitropoulos:generateTrace-tsconfig
Aug 15, 2024
Merged
allow generateTrace
in tsconfig and compiler API
#59636
sheetalkamat
merged 7 commits into
microsoft:main
from
dimitropoulos:generateTrace-tsconfig
Aug 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Uncommitted Bug
PR for untriaged, rejected, closed or missing bug
label
Aug 15, 2024
6 tasks
Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page. Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up. |
@microsoft-github-policy-service agree company="Vercel" |
sheetalkamat
approved these changes
Aug 15, 2024
thanks @sheetalkamat! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59617
Note
If it's at all possible to fit this in to 5.6 I'd be happy to immediate do whatever is required to make that happen: docs, more tests, diagrams, release notes, a full comedy routine about distributive conditionals, you-just-name-it.
I noticed there was actually already a baseline test for this (despite that it fails config parse validation in the latest release).