Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow generateTrace in tsconfig and compiler API #59636

Merged
merged 7 commits into from
Aug 15, 2024

Conversation

dimitropoulos
Copy link
Contributor

@dimitropoulos dimitropoulos commented Aug 15, 2024

Fixes #59617

Note

If it's at all possible to fit this in to 5.6 I'd be happy to immediate do whatever is required to make that happen: docs, more tests, diagrams, release notes, a full comedy routine about distributive conditionals, you-just-name-it.

I noticed there was actually already a baseline test for this (despite that it fails config parse validation in the latest release).

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Aug 15, 2024
@typescript-bot
Copy link
Collaborator

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up.

@dimitropoulos
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Vercel"

@sheetalkamat sheetalkamat merged commit 20f26a4 into microsoft:main Aug 15, 2024
32 checks passed
@dimitropoulos dimitropoulos deleted the generateTrace-tsconfig branch August 15, 2024 19:02
@dimitropoulos
Copy link
Contributor Author

thanks @sheetalkamat!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

add generateTrace to tsconfig's compilerOptions
3 participants