Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devcontainer.json Updates #59694

Merged
merged 3 commits into from
Aug 22, 2024
Merged

devcontainer.json Updates #59694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c6eac4b
Upgrade Node.js, switch entirely to devcontainer.json, install pprof.
DanielRosenwasser Aug 20, 2024
d6f6f7f
Spaces.
DanielRosenwasser Aug 20, 2024
e663e45
Fix accidentally removed field `groups`.
DanielRosenwasser Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions .devcontainer/Dockerfile
View file
Open in desktop

This file was deleted.

27 changes: 22 additions & 5 deletions .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,26 @@
// For format details, see https://aka.ms/devcontainer.json. For config options, see the
// README at: https://github.com/devcontainers/templates/tree/main/src/javascript-node
{
"name": "Node.js",
"build": {
"dockerfile": "Dockerfile",
"args": {
"VARIANT": "18"
}
// Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile
"image": "mcr.microsoft.com/devcontainers/javascript-node:1-22-bookworm",

// Features to add to the dev container. More info: https://containers.dev/features.
"features": {
"ghcr.io/devcontainers/features/go:1": {}
},

// Use 'forwardPorts' to make a list of ports inside the container available locally.
// "forwardPorts": [],

// Use 'postCreateCommand' to run commands after the container is created.
"postCreateCommand": {
"Configure Build Tools": "sudo corepack enable npm; sudo npm install -g hereby; npm ci",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wish this didn't need to be sudo :(

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but this is the same as what was happening in the Dockerfile, so I don't really feel like there's anything wrong with it.

"Install pprof": "go install github.com/google/pprof@latest",
"Install Graphviz": "sudo apt install graphviz"
},

// Configure tool-specific properties.
"customizations": {
"vscode": {
"settings": {
Expand All @@ -23,5 +38,7 @@
]
}
},

// More info: https://aka.ms/dev-containers-non-root.
"remoteUser": "node"
}
8 changes: 7 additions & 1 deletion .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
# To get started with Dependabot version updates, you'll need to specify which
# package ecosystems to update and where the package manifests are located.
# Please see the documentation for all configuration options:
# Please see the documentation for more information:
# https://docs.github.com/github/administering-a-repository/configuration-options-for-dependency-updates
# https://containers.dev/guide/dependabot

version: 2
updates:
Expand All @@ -13,3 +14,8 @@ updates:
github-actions:
patterns:
- '*'

- package-ecosystem: 'devcontainers'
directory: '/'
schedule:
interval: weekly