Refactor tsserver, tsc and fourslash-server tests so that paths are always watchable #59844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e : unless testcase is for unwatchable scenario TODOs: - Typing installer test failing because of using incorrect "current directory" - lib file always: - External project => tsconfig: - inferred projects use current directory as "vscode" - Some of the semantic diagnostics use - full paths rather than relative paths - tsbuildInfo??
TODO: - change verifyTsc to use vfsWithWatch so that we can unify some of the verifications
typescript-bot
added
Author: Team
For Uncommitted Bug
sheetalkamat
force-pushed
the
testsRefactoring
branch
from
b31427d
to
40df39b
Compare
sheetalkamat
changed the title
andrewbranch
reviewed
Sep 4, 2024
andrewbranch
reviewed
Sep 4, 2024
…vice This helps with diagnosing issues with the watching
|
@andrewbranch ready for re-review. Thanks |
andrewbranch
approved these changes
Sep 4, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is precursor to increase the coverage for tsserver resolution sharing:
/home/src/vscode/projects/bin/home/src/typinginstaller/globalcache/data/home/src/tslibs/ts/libThis discovered issues:
~/Libraryleading to access prompts #59831 since its setting directory watcher in vscode directory which in tests framework use to be "/"tests/cases/fourslash/server/autoImportProvider_exportMap3.tsbecause it was matched by tsconfig at "/". I left it like that where it fails to resolve lib and updated test to match "includes" and "excludes" instead of exact: "globalPlus" + "include" as globals for esnext i didnt want to encode. Also i remembered some conversation about trying to use default lib unless test absolutely needs it so left it like that.