Support importHelpers with module:preserve #59852
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we shipped
module: preserve
we did not include full support forimportHelpers
, which injects an import for thetslib
helper library. This changes our emit in the following ways when these two features are combined:.mts
/.mjs
file, we will emitimport { __helper } from "tslib";
to the output file and reference the helper using the imported name (e.g.,__helper
)..cts
/.cjs
file, we will emitconst tslib_1 = require("tslib");
to the output file and reference the helper using a qualified name (e.g.,tslib_1.__helper
)..ts
/.js
file, we will fall back to the.mts
/.mjs
behavior, above.It's important to note that
module: preserve
does not imply a module format for.ts
/.js
input files regardless as to the value of"type"
in package.json, so we will assume ESM for that case.Fixes #59789