Explicitly exclude . and .. for fs.readdirSync #7676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const files = _fs.readdirSync(path || ".").sort(); | ||
| // This filtering is necessary because on some file system node fails to exclude | ||
| // "." and "..". See https://github.com/nodejs/node/issues/4002 | ||
| const files = filter(<string[]>_fs.readdirSync(path || "."), f => f !== "." && f !== "..").sort(); | ||
| const directories: string[] = []; | ||
| for (const current of files) { | ||
| const name = combinePaths(path, current); |
There was a problem hiding this comment.
how about if (current === "." || current === "..") continue; instead of the filter.
There was a problem hiding this comment.
Would be better. Updated.
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7469
Exclude "." and ".." from the
fs.readdirresult explicitly due to the node bug that in some cases it fails to exclude these two items. (See microsoft/vscode#3860 and nodejs/node#4002)