Entity/Media/Service class derivatives on Class #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Completes Odcm model changes for Issue #30 |
| @@ -53,6 +54,7 @@ public void AddType(OdcmType type) | |||
| } | |||
|
|
|||
| _Types.Add(type); | |||
| ; | |||
There was a problem hiding this comment.
unnecessary semicolon
|
LGTM, aside from comments. |
tonycrider
force-pushed
the
CollectionFix
branch
from
456b438
to
b385f26
Compare
[1] Introduced OdcmEntityClass, OdcmMediaClass, OdcmServiceClass. [2] Enforce and propagate CanonicalName throughout model. [3] Updated readers to better handle type resolution through three stage approach: (1) first stage introduces Edm primitives, (2) second stage introduces shallow types from Edmx, and (3) third stage completes type decomposition. [4] Add support for DefaultValue in OdcmProperty.
tonycrider
force-pushed
the
CollectionFix
branch
from
b385f26
to
d76a5c8
Compare
tonycrider
added a commit
that referenced
this pull request
Feb 20, 2015
Entity/Media/Service class derivatives on Class
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Entity/Media/Service class derivatives on Class. Updated readers to better handle type resolution through three stage approach: (1) first stage introduces Edm primitives, (2) second stage introduces shallow types from Edmx, and (3) third stage completes type decomposition.